From d983a4ebcb481eb3fef9080c1262b8e64997220b Mon Sep 17 00:00:00 2001
From: "Feng.YJ" <32027253+huiyifyj@users.noreply.github.com>
Date: Sun, 9 Feb 2025 18:30:56 +0800
Subject: [PATCH] refactor(cmd): use std `runtime` package to get go version
 info (#7964)

* refactor(cmd): use std `runtime` package to get go version info

- Remove the `GoVersion` variable.
- Remove overriding `GoVersion` by ldflags in `build.sh`.
- Get go version, OS and arch from the constants in the std `runtime` package instead of compile time.

* chore(ci): remove `GoVersion` flag from workflows

Remove GoVersion flag from beta_release.yml and build.yml workflows.

> Reduce compile-time dependencies.
---
 .github/workflows/beta_release.yml | 1 -
 .github/workflows/build.yml        | 1 -
 build.sh                           | 2 --
 cmd/version.go                     | 6 ++++--
 internal/conf/var.go               | 1 -
 5 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/beta_release.yml b/.github/workflows/beta_release.yml
index 3c52b4c4..485942c4 100644
--- a/.github/workflows/beta_release.yml
+++ b/.github/workflows/beta_release.yml
@@ -94,7 +94,6 @@ jobs:
           out-dir: build
           x-flags: |
             github.com/alist-org/alist/v3/internal/conf.BuiltAt=$built_at
-            github.com/alist-org/alist/v3/internal/conf.GoVersion=$go_version
             github.com/alist-org/alist/v3/internal/conf.GitAuthor=Xhofe
             github.com/alist-org/alist/v3/internal/conf.GitCommit=$git_commit
             github.com/alist-org/alist/v3/internal/conf.Version=$tag
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index fe037f43..a2c934e7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -49,7 +49,6 @@ jobs:
           out-dir: build
           x-flags: |
             github.com/alist-org/alist/v3/internal/conf.BuiltAt=$built_at
-            github.com/alist-org/alist/v3/internal/conf.GoVersion=$go_version
             github.com/alist-org/alist/v3/internal/conf.GitAuthor=Xhofe
             github.com/alist-org/alist/v3/internal/conf.GitCommit=$git_commit
             github.com/alist-org/alist/v3/internal/conf.Version=$tag
diff --git a/build.sh b/build.sh
index d6e001c2..2dee8e20 100644
--- a/build.sh
+++ b/build.sh
@@ -1,6 +1,5 @@
 appName="alist"
 builtAt="$(date +'%F %T %z')"
-goVersion=$(go version | sed 's/go version //')
 gitAuthor="Xhofe <i@nn.ci>"
 gitCommit=$(git log --pretty=format:"%h" -1)
 
@@ -22,7 +21,6 @@ echo "frontend version: $webVersion"
 ldflags="\
 -w -s \
 -X 'github.com/alist-org/alist/v3/internal/conf.BuiltAt=$builtAt' \
--X 'github.com/alist-org/alist/v3/internal/conf.GoVersion=$goVersion' \
 -X 'github.com/alist-org/alist/v3/internal/conf.GitAuthor=$gitAuthor' \
 -X 'github.com/alist-org/alist/v3/internal/conf.GitCommit=$gitCommit' \
 -X 'github.com/alist-org/alist/v3/internal/conf.Version=$version' \
diff --git a/cmd/version.go b/cmd/version.go
index cdf4d71f..a758816e 100644
--- a/cmd/version.go
+++ b/cmd/version.go
@@ -6,6 +6,7 @@ package cmd
 import (
 	"fmt"
 	"os"
+	"runtime"
 
 	"github.com/alist-org/alist/v3/internal/conf"
 	"github.com/spf13/cobra"
@@ -16,14 +17,15 @@ var VersionCmd = &cobra.Command{
 	Use:   "version",
 	Short: "Show current version of AList",
 	Run: func(cmd *cobra.Command, args []string) {
+		goVersion := fmt.Sprintf("%s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH)
+
 		fmt.Printf(`Built At: %s
 Go Version: %s
 Author: %s
 Commit ID: %s
 Version: %s
 WebVersion: %s
-`,
-			conf.BuiltAt, conf.GoVersion, conf.GitAuthor, conf.GitCommit, conf.Version, conf.WebVersion)
+`, conf.BuiltAt, goVersion, conf.GitAuthor, conf.GitCommit, conf.Version, conf.WebVersion)
 		os.Exit(0)
 	},
 }
diff --git a/internal/conf/var.go b/internal/conf/var.go
index 0a8eb16f..7ae1a5ab 100644
--- a/internal/conf/var.go
+++ b/internal/conf/var.go
@@ -7,7 +7,6 @@ import (
 
 var (
 	BuiltAt    string
-	GoVersion  string
 	GitAuthor  string
 	GitCommit  string
 	Version    string = "dev"