From b14d2b438bfd399fcc8eadf29332752fa069c76a Mon Sep 17 00:00:00 2001
From: okatu-loli <CN_QianShi@hotmail.com>
Date: Tue, 19 Aug 2025 13:51:57 +0800
Subject: [PATCH] fix(setting): ensure DefaultRole stores role ID while
 exposing role name in APIs

- Simplified initial settings to use `model.GUEST` as the default role ID instead of querying roles at startup.
- Updated `GetSetting`, `ListSettings` handlers to:
  - Convert stored role ID into the corresponding role name when returning data.
  - Preserve dynamic role options for selection.
- Removed unused `strings` import and role preloading logic from `InitialSettings`.
- This change avoids DB dependency during initialization while keeping consistent role display for frontend clients.
---
 internal/bootstrap/data/setting.go | 19 ++-----------------
 server/handles/setting.go          | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/internal/bootstrap/data/setting.go b/internal/bootstrap/data/setting.go
index 39c3b1be..17a63af2 100644
--- a/internal/bootstrap/data/setting.go
+++ b/internal/bootstrap/data/setting.go
@@ -2,7 +2,6 @@ package data
 
 import (
 	"strconv"
-	"strings"
 
 	"github.com/alist-org/alist/v3/cmd/flags"
 	"github.com/alist-org/alist/v3/internal/conf"
@@ -92,21 +91,7 @@ func InitialSettings() []model.SettingItem {
 	} else {
 		token = random.Token()
 	}
-	roles, _, err := op.GetRoles(1, model.MaxInt)
-	if err != nil {
-		utils.Log.Fatalf("failed get roles: %+v", err)
-	}
-	roleNames := make([]string, len(roles))
-	defaultRoleID := ""
-	for i, role := range roles {
-		roleNames[i] = role.Name
-		if role.Name == "guest" {
-			defaultRoleID = strconv.Itoa(int(role.ID))
-		}
-	}
-	if defaultRoleID == "" && len(roles) > 0 {
-		defaultRoleID = strconv.Itoa(int(roles[0].ID))
-	}
+	defaultRoleID := strconv.Itoa(model.GUEST)
 	initialSettingItems = []model.SettingItem{
 		// site settings
 		{Key: conf.VERSION, Value: conf.Version, Type: conf.TypeString, Group: model.SITE, Flag: model.READONLY},
@@ -120,7 +105,7 @@ func InitialSettings() []model.SettingItem {
 		{Key: conf.AllowMounted, Value: "true", Type: conf.TypeBool, Group: model.SITE},
 		{Key: conf.RobotsTxt, Value: "User-agent: *\nAllow: /", Type: conf.TypeText, Group: model.SITE},
 		{Key: conf.AllowRegister, Value: "false", Type: conf.TypeBool, Group: model.SITE},
-		{Key: conf.DefaultRole, Value: defaultRoleID, Type: conf.TypeSelect, Options: strings.Join(roleNames, ","), Group: model.SITE},
+		{Key: conf.DefaultRole, Value: defaultRoleID, Type: conf.TypeSelect, Group: model.SITE},
 		// newui settings
 		{Key: conf.UseNewui, Value: "false", Type: conf.TypeBool, Group: model.SITE},
 		// style settings
diff --git a/server/handles/setting.go b/server/handles/setting.go
index 3ce5fcbf..2cfb07fe 100644
--- a/server/handles/setting.go
+++ b/server/handles/setting.go
@@ -49,6 +49,11 @@ func GetSetting(c *gin.Context) {
 		if item.Key == conf.DefaultRole {
 			copy := *item
 			copy.Options = getRoleOptions()
+			if id, err := strconv.Atoi(copy.Value); err == nil {
+				if r, err := op.GetRole(uint(id)); err == nil {
+					copy.Value = r.Name
+				}
+			}
 			common.SuccessResp(c, copy)
 			return
 		}
@@ -61,6 +66,11 @@ func GetSetting(c *gin.Context) {
 		}
 		for i := range items {
 			if items[i].Key == conf.DefaultRole {
+				if id, err := strconv.Atoi(items[i].Value); err == nil {
+					if r, err := op.GetRole(uint(id)); err == nil {
+						items[i].Value = r.Name
+					}
+				}
 				items[i].Options = getRoleOptions()
 				break
 			}
@@ -114,6 +124,11 @@ func ListSettings(c *gin.Context) {
 	}
 	for i := range settings {
 		if settings[i].Key == conf.DefaultRole {
+			if id, err := strconv.Atoi(settings[i].Value); err == nil {
+				if r, err := op.GetRole(uint(id)); err == nil {
+					settings[i].Value = r.Name
+				}
+			}
 			settings[i].Options = getRoleOptions()
 			break
 		}