From 09e63027d95873bd39de908fb58c160389314a81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=AE=E5=87=89?= <927625802@qq.com>
Date: Wed, 8 Dec 2021 19:36:07 +0800
Subject: [PATCH] :sparkler: allow delete deprecated setting

---
 bootstrap/setting.go          | 30 +++++++++++++++++++++++-------
 conf/var.go                   |  2 +-
 model/setting.go              | 12 ++++++++++--
 server/controllers/setting.go |  9 +++++++++
 server/router.go              |  2 ++
 5 files changed, 45 insertions(+), 10 deletions(-)

diff --git a/bootstrap/setting.go b/bootstrap/setting.go
index 3e4e4093..b85a59b0 100644
--- a/bootstrap/setting.go
+++ b/bootstrap/setting.go
@@ -15,9 +15,13 @@ func InitSettings() {
 		Description: "version",
 		Type:        "string",
 		Group:       model.CONST,
+		Version:     conf.GitTag,
 	}
 
-	_ = model.SaveSetting(version)
+	err := model.SaveSetting(version)
+	if err != nil {
+		log.Fatalf("failed write setting: %s", err.Error())
+	}
 
 	settings := []model.SettingItem{
 		{
@@ -114,8 +118,8 @@ func InitSettings() {
 			Group:       model.PRIVATE,
 		},
 		{
-			Key:         "customize head",
-			Value:       `<style>
+			Key: "customize head",
+			Value: `<style>
 .chakra-ui-light{
   background-image: linear-gradient(120deg,#e0c3fc 0%,#8ec5fc 100%) !important;
   background-attachment: fixed;
@@ -173,10 +177,22 @@ func InitSettings() {
 			Group:       model.PRIVATE,
 		},
 	}
-	for _, v := range settings {
-		_, err := model.GetSettingByKey(v.Key)
-		if err == gorm.ErrRecordNotFound {
-			err = model.SaveSetting(v)
+	for i, _ := range settings {
+		v := settings[i]
+		v.Version = conf.GitTag
+		o, err := model.GetSettingByKey(v.Key)
+		if err != nil {
+			if err == gorm.ErrRecordNotFound {
+				err = model.SaveSetting(v)
+				if err != nil {
+					log.Fatalf("failed write setting: %s", err.Error())
+				}
+			} else {
+				log.Fatal("can't get setting: %s", err.Error())
+			}
+		} else {
+			o.Version = conf.GitTag
+			err = model.SaveSetting(*o)
 			if err != nil {
 				log.Fatalf("failed write setting: %s", err.Error())
 			}
diff --git a/conf/var.go b/conf/var.go
index 17bcd787..e464c050 100644
--- a/conf/var.go
+++ b/conf/var.go
@@ -12,7 +12,7 @@ var (
 	GoVersion string
 	GitAuthor string
 	GitCommit string
-	GitTag    string
+	GitTag    string = "dev"
 )
 
 var (
diff --git a/model/setting.go b/model/setting.go
index 31b6c011..671e1339 100644
--- a/model/setting.go
+++ b/model/setting.go
@@ -20,6 +20,7 @@ type SettingItem struct {
 	Type        string `json:"type"`
 	Group       int    `json:"group"`
 	Values      string `json:"values"`
+	Version     string `json:"version"`
 }
 
 func SaveSettings(items []SettingItem) error {
@@ -46,6 +47,13 @@ func GetSettings() (*[]SettingItem, error) {
 	return &items, nil
 }
 
+func DeleteSetting(key string) error {
+	setting := SettingItem{
+		Key: key,
+	}
+	return conf.DB.Delete(&setting).Error
+}
+
 func GetSettingByKey(key string) (*SettingItem, error) {
 	var items SettingItem
 	if err := conf.DB.Where("`key` = ?", key).First(&items).Error; err != nil {
@@ -63,7 +71,7 @@ func LoadSettings() {
 	if err == nil {
 		conf.CheckParent = checkParent.Value == "true"
 	}
-	checkDown,err := GetSettingByKey("check down link")
+	checkDown, err := GetSettingByKey("check down link")
 	if err == nil {
 		conf.CheckDown = checkDown.Value == "true"
 	}
@@ -87,7 +95,7 @@ func LoadSettings() {
 
 	adminPassword, err := GetSettingByKey("password")
 	if err == nil {
-		conf.Token = utils.GetMD5Encode(fmt.Sprintf("https://github.com/Xhofe/alist-%s",adminPassword.Value))
+		conf.Token = utils.GetMD5Encode(fmt.Sprintf("https://github.com/Xhofe/alist-%s", adminPassword.Value))
 	}
 
 	davUsername, err := GetSettingByKey("WebDAV username")
diff --git a/server/controllers/setting.go b/server/controllers/setting.go
index 875ea5f7..59f79d22 100644
--- a/server/controllers/setting.go
+++ b/server/controllers/setting.go
@@ -37,3 +37,12 @@ func GetSettingsPublic(c *gin.Context) {
 	}
 	common.SuccessResp(c, settings)
 }
+
+func DeleteSetting(c *gin.Context) {
+	key := c.Query("key")
+	if err := model.DeleteSetting(key); err != nil {
+		common.ErrorResp(c, err, 500)
+		return
+	}
+	common.SuccessResp(c)
+}
diff --git a/server/router.go b/server/router.go
index b6079d19..36f71ed8 100644
--- a/server/router.go
+++ b/server/router.go
@@ -33,6 +33,8 @@ func InitApiRouter(r *gin.Engine) {
 		admin.GET("/login", common.Login)
 		admin.GET("/settings", controllers.GetSettings)
 		admin.POST("/settings", controllers.SaveSettings)
+		admin.DELETE("/setting", controllers.DeleteSetting)
+
 		admin.POST("/account/create", controllers.CreateAccount)
 		admin.POST("/account/save", controllers.SaveAccount)
 		admin.GET("/accounts", controllers.GetAccounts)