Add missing @Serial annotations

master
Richard Körber 2025-04-26 12:49:45 +02:00
parent ba50d4ec72
commit feee96444f
No known key found for this signature in database
GPG Key ID: AAB9FD19C78AA3E0
9 changed files with 18 additions and 0 deletions

View File

@ -13,6 +13,7 @@
*/ */
package org.shredzone.acme4j; package org.shredzone.acme4j;
import java.io.Serial;
import java.net.URL; import java.net.URL;
import java.time.Instant; import java.time.Instant;
import java.util.Objects; import java.util.Objects;
@ -32,6 +33,7 @@ import org.slf4j.LoggerFactory;
* fetching it from the server if necessary. * fetching it from the server if necessary.
*/ */
public abstract class AcmeJsonResource extends AcmeResource { public abstract class AcmeJsonResource extends AcmeResource {
@Serial
private static final long serialVersionUID = -5060364275766082345L; private static final long serialVersionUID = -5060364275766082345L;
private static final Logger LOG = LoggerFactory.getLogger(AcmeJsonResource.class); private static final Logger LOG = LoggerFactory.getLogger(AcmeJsonResource.class);

View File

@ -13,6 +13,7 @@
*/ */
package org.shredzone.acme4j; package org.shredzone.acme4j;
import java.io.Serial;
import java.io.Serializable; import java.io.Serializable;
import java.net.URL; import java.net.URL;
import java.util.Objects; import java.util.Objects;
@ -28,6 +29,7 @@ import edu.umd.cs.findbugs.annotations.Nullable;
* using {@link #rebind(Login)}. * using {@link #rebind(Login)}.
*/ */
public abstract class AcmeResource implements Serializable { public abstract class AcmeResource implements Serializable {
@Serial
private static final long serialVersionUID = -7930580802257379731L; private static final long serialVersionUID = -7930580802257379731L;
private transient @Nullable Login login; private transient @Nullable Login login;

View File

@ -15,6 +15,7 @@ package org.shredzone.acme4j;
import static java.util.stream.Collectors.toUnmodifiableList; import static java.util.stream.Collectors.toUnmodifiableList;
import java.io.Serial;
import java.net.URL; import java.net.URL;
import java.time.Duration; import java.time.Duration;
import java.time.Instant; import java.time.Instant;
@ -35,6 +36,7 @@ import org.slf4j.LoggerFactory;
* Represents an authorization request at the ACME server. * Represents an authorization request at the ACME server.
*/ */
public class Authorization extends AcmeJsonResource implements PollableResource { public class Authorization extends AcmeJsonResource implements PollableResource {
@Serial
private static final long serialVersionUID = -3116928998379417741L; private static final long serialVersionUID = -3116928998379417741L;
private static final Logger LOG = LoggerFactory.getLogger(Authorization.class); private static final Logger LOG = LoggerFactory.getLogger(Authorization.class);

View File

@ -20,6 +20,7 @@ import static java.util.stream.Collectors.toUnmodifiableList;
import static org.shredzone.acme4j.toolbox.AcmeUtils.getRenewalUniqueIdentifier; import static org.shredzone.acme4j.toolbox.AcmeUtils.getRenewalUniqueIdentifier;
import java.io.IOException; import java.io.IOException;
import java.io.Serial;
import java.io.Writer; import java.io.Writer;
import java.net.MalformedURLException; import java.net.MalformedURLException;
import java.net.URL; import java.net.URL;
@ -50,6 +51,7 @@ import org.slf4j.LoggerFactory;
* ordered. * ordered.
*/ */
public class Certificate extends AcmeResource { public class Certificate extends AcmeResource {
@Serial
private static final long serialVersionUID = 7381527770159084201L; private static final long serialVersionUID = 7381527770159084201L;
private static final Logger LOG = LoggerFactory.getLogger(Certificate.class); private static final Logger LOG = LoggerFactory.getLogger(Certificate.class);

View File

@ -17,6 +17,7 @@ import static java.util.Collections.unmodifiableMap;
import static java.util.Objects.requireNonNull; import static java.util.Objects.requireNonNull;
import static org.shredzone.acme4j.toolbox.AcmeUtils.toAce; import static org.shredzone.acme4j.toolbox.AcmeUtils.toAce;
import java.io.Serial;
import java.io.Serializable; import java.io.Serializable;
import java.net.InetAddress; import java.net.InetAddress;
import java.net.UnknownHostException; import java.net.UnknownHostException;
@ -37,6 +38,7 @@ import org.shredzone.acme4j.toolbox.JSON;
* @since 2.3 * @since 2.3
*/ */
public class Identifier implements Serializable { public class Identifier implements Serializable {
@Serial
private static final long serialVersionUID = -7777851842076362412L; private static final long serialVersionUID = -7777851842076362412L;
/** /**

View File

@ -13,6 +13,7 @@
*/ */
package org.shredzone.acme4j.exception; package org.shredzone.acme4j.exception;
import java.io.Serial;
import java.time.Instant; import java.time.Instant;
import java.util.Objects; import java.util.Objects;
@ -30,6 +31,7 @@ import org.shredzone.acme4j.AcmeJsonResource;
*/ */
@Deprecated @Deprecated
public class AcmeRetryAfterException extends AcmeException { public class AcmeRetryAfterException extends AcmeException {
@Serial
private static final long serialVersionUID = 4461979121063649905L; private static final long serialVersionUID = 4461979121063649905L;
private final Instant retryAfter; private final Instant retryAfter;

View File

@ -17,6 +17,7 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.shredzone.acme4j.toolbox.TestUtils.getJSON; import static org.shredzone.acme4j.toolbox.TestUtils.getJSON;
import static org.shredzone.acme4j.toolbox.TestUtils.url; import static org.shredzone.acme4j.toolbox.TestUtils.url;
import java.io.Serial;
import java.net.URL; import java.net.URL;
import java.time.Instant; import java.time.Instant;
import java.util.Optional; import java.util.Optional;
@ -140,6 +141,7 @@ public class AcmeJsonResourceTest {
* Minimum implementation of {@link AcmeJsonResource}. * Minimum implementation of {@link AcmeJsonResource}.
*/ */
private static class DummyJsonResource extends AcmeJsonResource { private static class DummyJsonResource extends AcmeJsonResource {
@Serial
private static final long serialVersionUID = -6459238185161771948L; private static final long serialVersionUID = -6459238185161771948L;
private int updateCount = 0; private int updateCount = 0;

View File

@ -20,6 +20,7 @@ import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
import java.io.ObjectInputStream; import java.io.ObjectInputStream;
import java.io.ObjectOutputStream; import java.io.ObjectOutputStream;
import java.io.Serial;
import java.net.URL; import java.net.URL;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
@ -113,6 +114,7 @@ public class AcmeResourceTest {
* Minimum implementation of {@link AcmeResource}. * Minimum implementation of {@link AcmeResource}.
*/ */
private static class DummyResource extends AcmeResource { private static class DummyResource extends AcmeResource {
@Serial
private static final long serialVersionUID = 7188822681353082472L; private static final long serialVersionUID = 7188822681353082472L;
public DummyResource(Login login, URL location) { public DummyResource(Login login, URL location) {
super(login, location); super(login, location);

View File

@ -16,6 +16,7 @@ package org.shredzone.acme4j.exception;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import java.io.Serial;
import java.net.URL; import java.net.URL;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -47,6 +48,7 @@ public class AcmeLazyLoadingExceptionTest {
} }
private static class TestResource extends AcmeResource { private static class TestResource extends AcmeResource {
@Serial
private static final long serialVersionUID = 1023419539450677538L; private static final long serialVersionUID = 1023419539450677538L;
public TestResource(Login login, URL location) { public TestResource(Login login, URL location) {