github
/
acme4j
mirror of https://github.com/shred/acme4j
1
0
Fork 0
Code Issues Releases Wiki Activity

Pebble does not support kid header yet

pull/55/head
Richard Körber 2017-04-27 22:38:54 +02:00
parent 4772488896
commit ee3765e543
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
acme4j-client/src/main/java/org/shredzone/acme4j/connector/DefaultConnection.java
View File

@ -182,7 +182,10 @@ public class DefaultConnection implements Connection {
jws.getHeaders().setObjectHeaderValue("nonce", Base64Url.encode(session.getNonce())); jws.getHeaders().setObjectHeaderValue("nonce", Base64Url.encode(session.getNonce()));
jws.getHeaders().setObjectHeaderValue("url", url); jws.getHeaders().setObjectHeaderValue("url", url);
if (session.getKeyIdentifier() != null) { if (session.getKeyIdentifier() != null) {
jws.getHeaders().setObjectHeaderValue("kid", session.getKeyIdentifier()); // TODO PEBBLE: cannot process "kid" yet, send "jwk" instead
// https://github.com/letsencrypt/pebble/issues/23
// jws.getHeaders().setObjectHeaderValue("kid", session.getKeyIdentifier());
jws.getHeaders().setJwkHeaderValue("jwk", jwk);
} else { } else {
jws.getHeaders().setJwkHeaderValue("jwk", jwk); jws.getHeaders().setJwkHeaderValue("jwk", jwk);
} }

3
acme4j-client/src/test/java/org/shredzone/acme4j/connector/DefaultConnectionTest.java
View File

@ -615,7 +615,8 @@ public class DefaultConnectionTest {
expectedHeader.append("\"kid\":\"").append(keyIdentifier).append('"'); expectedHeader.append("\"kid\":\"").append(keyIdentifier).append('"');
expectedHeader.append('}'); expectedHeader.append('}');
assertThat(header, sameJSONAs(expectedHeader.toString())); // TODO PEBBLE: cannot process "kid" yet, send "jwk" instead
// assertThat(header, sameJSONAs(expectedHeader.toString()));
assertThat(claims, sameJSONAs("{\"foo\":123,\"bar\":\"a-string\"}")); assertThat(claims, sameJSONAs("{\"foo\":123,\"bar\":\"a-string\"}"));
assertThat(signature, not(isEmptyOrNullString())); assertThat(signature, not(isEmptyOrNullString()));