From edb7ec83b64a1dea9348bc3731e5610171b5b700 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20K=C3=B6rber?= Date: Tue, 6 Feb 2024 18:20:44 +0100 Subject: [PATCH] Generic ACME URIs forward query parameters (#152) --- .../java/org/shredzone/acme4j/provider/GenericAcmeProvider.java | 2 +- .../org/shredzone/acme4j/provider/GenericAcmeProviderTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/acme4j-client/src/main/java/org/shredzone/acme4j/provider/GenericAcmeProvider.java b/acme4j-client/src/main/java/org/shredzone/acme4j/provider/GenericAcmeProvider.java index 39e4fb50..2609e639 100644 --- a/acme4j-client/src/main/java/org/shredzone/acme4j/provider/GenericAcmeProvider.java +++ b/acme4j-client/src/main/java/org/shredzone/acme4j/provider/GenericAcmeProvider.java @@ -34,7 +34,7 @@ public class GenericAcmeProvider extends AbstractAcmeProvider { @Override public URL resolve(URI serverUri) { try { - return new URL(serverUri.getScheme(), serverUri.getHost(), serverUri.getPort(), serverUri.getPath()); + return serverUri.toURL(); } catch (MalformedURLException ex) { throw new IllegalArgumentException("Bad generic server URI", ex); } diff --git a/acme4j-client/src/test/java/org/shredzone/acme4j/provider/GenericAcmeProviderTest.java b/acme4j-client/src/test/java/org/shredzone/acme4j/provider/GenericAcmeProviderTest.java index 6bdb9cf9..d60d8c32 100644 --- a/acme4j-client/src/test/java/org/shredzone/acme4j/provider/GenericAcmeProviderTest.java +++ b/acme4j-client/src/test/java/org/shredzone/acme4j/provider/GenericAcmeProviderTest.java @@ -44,7 +44,7 @@ public class GenericAcmeProviderTest { */ @Test public void testResolve() throws URISyntaxException { - var serverUri = new URI("http://example.com/acme"); + var serverUri = new URI("http://example.com/acme?foo=abc&bar=123"); var provider = new GenericAcmeProvider();