github
/
acme4j
mirror of https://github.com/shred/acme4j
1
0
Fork 0
Code Issues Releases Wiki Activity

replaced assertEquals, being missed before. Added Javadoc

pull/134/head
kimmerin 2022-05-25 12:06:36 +02:00 committed by Richard Körber
parent 6ea7b30cdf
commit e851acd61d
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
acme4j-utils/src/test/java/org/shredzone/acme4j/util/CSRBuilderTest.java
View File

@ -15,7 +15,6 @@ package org.shredzone.acme4j.util;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType; import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.junit.Assert.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
@ -134,7 +133,6 @@ public class CSRBuilderTest {
@Test @Test
public void testNoSign() throws IOException { public void testNoSign() throws IOException {
CSRBuilder builder = new CSRBuilder(); CSRBuilder builder = new CSRBuilder();
IllegalStateException ise;
assertThatExceptionOfType(IllegalStateException.class) assertThatExceptionOfType(IllegalStateException.class)
.isThrownBy(builder::getCSR) .isThrownBy(builder::getCSR)
@ -146,14 +144,24 @@ public class CSRBuilderTest {
.as("getCSR()") .as("getCSR()")
.withMessage("sign CSR first"); .withMessage("sign CSR first");
ise = assertThrows(IllegalStateException.class, () -> { assertThatExceptionOfType(IllegalStateException.class)
.isThrownBy(() -> {
try (StringWriter w = new StringWriter()) { try (StringWriter w = new StringWriter()) {
builder.write(w); builder.write(w);
} }
}, "write()"); })
assertEquals("unexpected exception message", "sign CSR first", ise.getMessage()); .as("builder.write()")
.withMessage("sign CSR first");
} }
/**
* Checks that addValue behaves correctly in dependence of the
* attributes being added. If a common name is set, it should
* be handled in the same way when it's added by using
* <code>addDomain</code>
* @throws Exception Will be thrown if there was an error
* while performing the test
*/
@Test @Test
public void testAddAttrValues() throws Exception { public void testAddAttrValues() throws Exception {
CSRBuilder builder = new CSRBuilder(); CSRBuilder builder = new CSRBuilder();