github
/
acme4j
mirror of https://github.com/shred/acme4j
1
0
Fork 0
Code Issues Releases Wiki Activity

Send kid instead of jwk when revoking a cert (fixes issue #62)

pull/66/head
Richard Körber 2018-04-16 19:40:34 +02:00
parent ee291da06b
commit cd7038a7fa
No known key found for this signature in database
GPG Key ID: AAB9FD19C78AA3E0
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
acme4j-client/src/main/java/org/shredzone/acme4j/Certificate.java
View File

@ -157,7 +157,7 @@ public class Certificate extends AcmeResource {
claims.put("reason", reason.getReasonCode()); claims.put("reason", reason.getReasonCode());
} }
conn.sendSignedRequest(resUrl, claims, getSession(), getLogin().getKeyPair()); conn.sendSignedRequest(resUrl, claims, getLogin());
} catch (CertificateEncodingException ex) { } catch (CertificateEncodingException ex) {
throw new AcmeProtocolException("Invalid certificate", ex); throw new AcmeProtocolException("Invalid certificate", ex);
} }

10
acme4j-client/src/test/java/org/shredzone/acme4j/CertificateTest.java
View File

@ -131,11 +131,10 @@ public class CertificateTest {
} }
@Override @Override
public int sendSignedRequest(URL url, JSONBuilder claims, Session session, KeyPair keypair) { public int sendSignedRequest(URL url, JSONBuilder claims, Login login) {
assertThat(url, is(resourceUrl)); assertThat(url, is(resourceUrl));
assertThat(claims.toString(), sameJSONAs(getJSON("revokeCertificateRequest").toString())); assertThat(claims.toString(), sameJSONAs(getJSON("revokeCertificateRequest").toString()));
assertThat(session, is(notNullValue())); assertThat(login, is(notNullValue()));
assertThat(keypair, is(notNullValue()));
certRequested = false; certRequested = false;
return HttpURLConnection.HTTP_OK; return HttpURLConnection.HTTP_OK;
} }
@ -179,11 +178,10 @@ public class CertificateTest {
} }
@Override @Override
public int sendSignedRequest(URL url, JSONBuilder claims, Session session, KeyPair keypair) { public int sendSignedRequest(URL url, JSONBuilder claims, Login login) {
assertThat(url, is(resourceUrl)); assertThat(url, is(resourceUrl));
assertThat(claims.toString(), sameJSONAs(getJSON("revokeCertificateWithReasonRequest").toString())); assertThat(claims.toString(), sameJSONAs(getJSON("revokeCertificateWithReasonRequest").toString()));
assertThat(session, is(notNullValue())); assertThat(login, is(notNullValue()));
assertThat(keypair, is(notNullValue()));
certRequested = false; certRequested = false;
return HttpURLConnection.HTTP_OK; return HttpURLConnection.HTTP_OK;
} }