github
/
acme4j
mirror of https://github.com/shred/acme4j
1
0
Fork 0
Code Issues Releases Wiki Activity

Skip challenge if authorization is already valid

pull/61/head
Richard Körber 2018-02-21 19:58:29 +01:00
parent d7c6ac659a
commit b1ac68181c
No known key found for this signature in database
GPG Key ID: AAB9FD19C78AA3E0
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
acme4j-example/src/main/java/org/shredzone/acme4j/ClientTest.java
View File

@ -204,6 +204,11 @@ public class ClientTest {
private void authorize(Authorization auth) throws AcmeException { private void authorize(Authorization auth) throws AcmeException {
LOG.info("Authorization for domain " + auth.getDomain()); LOG.info("Authorization for domain " + auth.getDomain());
// The authorization is already valid. No need to process a challenge.
if (auth.getStatus() == Status.VALID) {
return;
}
// Find the desired challenge and prepare it. // Find the desired challenge and prepare it.
Challenge challenge = null; Challenge challenge = null;
switch (CHALLENGE_TYPE) { switch (CHALLENGE_TYPE) {

4
acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java
View File

@ -122,6 +122,10 @@ public class OrderIT extends PebbleITBase {
assertThat(auth.getDomain(), is(domain)); assertThat(auth.getDomain(), is(domain));
assertThat(auth.getStatus(), is(Status.PENDING)); assertThat(auth.getStatus(), is(Status.PENDING));
if (auth.getStatus() == Status.VALID) {
continue;
}
Challenge challenge = validator.prepare(auth); Challenge challenge = validator.prepare(auth);
challenge.trigger(); challenge.trigger();

4
acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java
View File

@ -80,6 +80,10 @@ public class OrderWildcardIT extends PebbleITBase {
assertThat(auth.getDomain(), is(TEST_DOMAIN)); assertThat(auth.getDomain(), is(TEST_DOMAIN));
assertThat(auth.getStatus(), is(Status.PENDING)); assertThat(auth.getStatus(), is(Status.PENDING));
if (auth.getStatus() == Status.VALID) {
continue;
}
Dns01Challenge challenge = auth.findChallenge(Dns01Challenge.TYPE); Dns01Challenge challenge = auth.findChallenge(Dns01Challenge.TYPE);
assertThat(challenge, is(notNullValue())); assertThat(challenge, is(notNullValue()));