github
/
acme4j
mirror of https://github.com/shred/acme4j
1
0
Fork 0
Code Issues Releases Wiki Activity

Return a copy of certificate chain array

acmev1
Richard Körber 2018-07-07 15:35:39 +02:00
parent 22ed05de8e
commit ae4ef0f2ab
No known key found for this signature in database
GPG Key ID: AAB9FD19C78AA3E0
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
acme4j-client/src/main/java/org/shredzone/acme4j/Certificate.java
View File

@ -19,6 +19,7 @@ import java.net.URL;
import java.security.cert.CertificateEncodingException; import java.security.cert.CertificateEncodingException;
import java.security.cert.X509Certificate; import java.security.cert.X509Certificate;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.List; import java.util.List;
import org.shredzone.acme4j.connector.Connection; import org.shredzone.acme4j.connector.Connection;
@ -140,7 +141,7 @@ public class Certificate extends AcmeResource {
chain = certChain.toArray(new X509Certificate[certChain.size()]); chain = certChain.toArray(new X509Certificate[certChain.size()]);
} }
return chain; return Arrays.copyOf(chain, chain.length);
} }
/** /**

5
acme4j-client/src/test/java/org/shredzone/acme4j/CertificateTest.java
View File

@ -101,6 +101,11 @@ public class CertificateTest {
assertThat(downloadedChain.length, is(1)); assertThat(downloadedChain.length, is(1));
assertThat(downloadedChain[0], is(sameInstance(originalCert))); assertThat(downloadedChain[0], is(sameInstance(originalCert)));
// Make sure the chain array is a local copy
downloadedChain[0] = null;
X509Certificate[] downloadedChain2 = cert.downloadChain();
assertThat(downloadedChain2[0], is(sameInstance(originalCert)));
provider.close(); provider.close();
} }