From a949da99276679e5655053d6290def58b685c8f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20K=C3=B6rber?= Date: Wed, 22 Aug 2018 22:32:22 +0200 Subject: [PATCH] Fix proxy system properties in documentation --- src/site/markdown/usage/account.md | 2 +- src/site/markdown/usage/session.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/site/markdown/usage/account.md b/src/site/markdown/usage/account.md index 120461df..296f1423 100644 --- a/src/site/markdown/usage/account.md +++ b/src/site/markdown/usage/account.md @@ -71,7 +71,7 @@ Even if it is tempting to do so, you should not invoke `agreeToTermsOfService()` If the CA changes the terms of service and requires an explicit agreement to the new terms, an `AcmeUserActionRequiredException` is thrown. Its `getInstance()` method returns the URL of a document that gives instructions about how to agree to the new terms of service. There is no way to automatize this process. -## Find out Your Account's Location URL +## Find out your Account's Location URL If you only have your account's `KeyPair`, you can use the `AccountBuilder` to find out the location `URL` of your account. diff --git a/src/site/markdown/usage/session.md b/src/site/markdown/usage/session.md index 701ec180..e141552f 100644 --- a/src/site/markdown/usage/session.md +++ b/src/site/markdown/usage/session.md @@ -39,6 +39,6 @@ By default, the system's default locale is used. _acme4j_ uses a standard `HttpURLConnection` for HTTP connections. -If a proxy must be used for internet connections, you can set a `Proxy` instance by invoking `Session.setProxy()`. An alternative is to use the system properties `http.proxyHost` and `http.proxyPort` to globally set a proxy for the Java process. +If a proxy must be used for internet connections, you can set a `Proxy` instance by invoking `Session.setProxy()`. An alternative is to use the system properties `https.proxyHost` and `https.proxyPort` to globally set a proxy for the Java process. If the proxy needs authentication, you need to set a default `Authenticator`. Be careful: Most code snippets I have found in the internet will send out the proxy credentials to anyone who is asking. See [this blog article](http://rolandtapken.de/blog/2012-04/java-process-httpproxyuser-and-httpproxypassword) for a good way to implement a proxy `Authenticator`.