From a7ea703e939b9110543dd7b3abaf9b0c5b4317f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20K=C3=B6rber?= Date: Thu, 28 Dec 2017 00:07:58 +0100 Subject: [PATCH] Remove unnecessary type from challenge response --- .../src/main/java/org/shredzone/acme4j/challenge/Challenge.java | 2 +- .../test/java/org/shredzone/acme4j/challenge/ChallengeTest.java | 2 +- .../src/test/resources/json/triggerHttpChallengeRequest.json | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/acme4j-client/src/main/java/org/shredzone/acme4j/challenge/Challenge.java b/acme4j-client/src/main/java/org/shredzone/acme4j/challenge/Challenge.java index a77434f6..e24acd10 100644 --- a/acme4j-client/src/main/java/org/shredzone/acme4j/challenge/Challenge.java +++ b/acme4j-client/src/main/java/org/shredzone/acme4j/challenge/Challenge.java @@ -160,7 +160,7 @@ public class Challenge extends AcmeResource { * {@link JSONBuilder} to copy the response to */ protected void respond(JSONBuilder cb) { - cb.put(KEY_TYPE, getType()); + // Do nothing here... } /** diff --git a/acme4j-client/src/test/java/org/shredzone/acme4j/challenge/ChallengeTest.java b/acme4j-client/src/test/java/org/shredzone/acme4j/challenge/ChallengeTest.java index 414174ce..f01130ee 100644 --- a/acme4j-client/src/test/java/org/shredzone/acme4j/challenge/ChallengeTest.java +++ b/acme4j-client/src/test/java/org/shredzone/acme4j/challenge/ChallengeTest.java @@ -140,7 +140,7 @@ public class ChallengeTest { JSONBuilder cb = new JSONBuilder(); challenge.respond(cb); - assertThat(cb.toString(), sameJSONAs("{\"type\"=\"generic-01\"}")); + assertThat(cb.toString(), sameJSONAs("{}")); } /** diff --git a/acme4j-client/src/test/resources/json/triggerHttpChallengeRequest.json b/acme4j-client/src/test/resources/json/triggerHttpChallengeRequest.json index 51826a22..8ecbc882 100644 --- a/acme4j-client/src/test/resources/json/triggerHttpChallengeRequest.json +++ b/acme4j-client/src/test/resources/json/triggerHttpChallengeRequest.json @@ -1,4 +1,3 @@ { - "type": "http-01", "keyAuthorization": "IlirfxKKXAsHtmzK29Pj8A.HnWjTDnyqlCrm6tZ-6wX-TrEXgRdeNu9G71gqxSO6o0" }