From 59092daabad1f3bcdf5f11becd087d89ade6494e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Richard=20K=C3=B6rber?= <github@shredzone.org>
Date: Fri, 11 Dec 2015 18:36:22 +0100
Subject: [PATCH] Add more unit tests

---
 .../LetsEncryptAcmeClientProviderTest.java    | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/acme4j-letsencrypt/src/test/java/org/shredzone/acme4j/provider/LetsEncryptAcmeClientProviderTest.java b/acme4j-letsencrypt/src/test/java/org/shredzone/acme4j/provider/LetsEncryptAcmeClientProviderTest.java
index 5776e5dc..0279ea14 100644
--- a/acme4j-letsencrypt/src/test/java/org/shredzone/acme4j/provider/LetsEncryptAcmeClientProviderTest.java
+++ b/acme4j-letsencrypt/src/test/java/org/shredzone/acme4j/provider/LetsEncryptAcmeClientProviderTest.java
@@ -27,6 +27,7 @@ import javax.net.ssl.SSLSocketFactory;
 
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.shredzone.acme4j.AcmeClient;
 
 /**
  * Unit tests for {@link LetsEncryptAcmeClientProvider}.
@@ -37,6 +38,9 @@ public class LetsEncryptAcmeClientProviderTest {
 
     public interface RequiresNetwork {}
 
+    private static final String V01_DIRECTORY_URI = "https://acme-v01.api.letsencrypt.org/directory";
+    private static final String STAGING_DIRECTORY_URI = "https://acme-staging.api.letsencrypt.org/directory";
+
     /**
      * Tests if the provider accepts the correct URIs.
      */
@@ -53,6 +57,57 @@ public class LetsEncryptAcmeClientProviderTest {
         assertThat(provider.accepts(new URI("https://example.com/acme")), is(false));
     }
 
+    /**
+     * Test if acme URIs are properly resolved.
+     */
+    @Test
+    public void testResolve() throws URISyntaxException {
+        LetsEncryptAcmeClientProvider provider = new LetsEncryptAcmeClientProvider();
+
+        assertThat(provider.resolve(new URI("acme://letsencrypt.org")), is(new URI(V01_DIRECTORY_URI)));
+        assertThat(provider.resolve(new URI("acme://letsencrypt.org/")), is(new URI(V01_DIRECTORY_URI)));
+        assertThat(provider.resolve(new URI("acme://letsencrypt.org/v01")), is(new URI(V01_DIRECTORY_URI)));
+        assertThat(provider.resolve(new URI("acme://letsencrypt.org/staging")), is(new URI(STAGING_DIRECTORY_URI)));
+
+        try {
+            provider.resolve(new URI("acme://letsencrypt.org/v99"));
+            fail("accepted unknown path");
+        } catch (IllegalArgumentException ex) {
+            // expected
+        }
+
+        try {
+            provider.resolve(new URI("acme://example.com"));
+            fail("accepted foreign server");
+        } catch (IllegalArgumentException ex) {
+            // expected
+        }
+
+        try {
+            provider.resolve(new URI("http://example.com/acme"));
+            fail("accepted http schema");
+        } catch (IllegalArgumentException ex) {
+            // expected
+        }
+    }
+
+    /**
+     * Test if an {@link AcmeClient} is properly generated and configurated.
+     */
+    @Test
+    public void testConnect() throws URISyntaxException {
+        LetsEncryptAcmeClientProvider provider = new LetsEncryptAcmeClientProvider() {
+            @Override
+            protected AcmeClient createAcmeClient(URI directoryUri) {
+                assertThat(directoryUri.toString(), is(V01_DIRECTORY_URI));
+                return super.createAcmeClient(directoryUri);
+            }
+        };
+
+        AcmeClient client = provider.connect(new URI("acme://letsencrypt.org"));
+        assertThat(client, is(notNullValue()));
+    }
+
     /**
      * Test if the {@link LetsEncryptAcmeClientProvider#openConnection(URI)} accepts only
      * the Let's Encrypt certificate.