From 55516c2c3e5f01de1b510963b2ece0a87367c2a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20K=C3=B6rber?= Date: Sat, 31 Oct 2020 16:34:54 +0100 Subject: [PATCH] Compare notBefore and notAfter dates in cert --- .../src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java | 4 ++-- .../java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java b/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java index 2226e810..c8714c08 100644 --- a/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java +++ b/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderIT.java @@ -209,8 +209,8 @@ public class OrderIT extends PebbleITBase { Certificate certificate = order.getCertificate(); X509Certificate cert = certificate.getCertificate(); assertThat(cert, not(nullValue())); - assertThat(cert.getNotBefore().toInstant(), is(notNullValue())); - assertThat(cert.getNotAfter().toInstant(), is(notNullValue())); + assertThat(cert.getNotBefore().toInstant(), is(notBefore)); + assertThat(cert.getNotAfter().toInstant(), is(notAfter)); assertThat(cert.getSubjectX500Principal().getName(), containsString("CN=" + domain)); for (Authorization auth : order.getAuthorizations()) { diff --git a/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java b/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java index 0cc3d001..43733393 100644 --- a/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java +++ b/acme4j-it/src/test/java/org/shredzone/acme4j/it/pebble/OrderWildcardIT.java @@ -125,8 +125,8 @@ public class OrderWildcardIT extends PebbleITBase { Certificate certificate = order.getCertificate(); X509Certificate cert = certificate.getCertificate(); assertThat(cert, not(nullValue())); - assertThat(cert.getNotAfter(), not(nullValue())); - assertThat(cert.getNotBefore(), not(nullValue())); + assertThat(cert.getNotAfter(), not(notBefore)); + assertThat(cert.getNotBefore(), not(notAfter)); assertThat(cert.getSubjectX500Principal().getName(), containsString("CN=" + TEST_DOMAIN)); List san = cert.getSubjectAlternativeNames().stream()