From 4b968786889df7774bff8157e2e1d37f0ec7f010 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Richard=20K=C3=B6rber?= Date: Mon, 1 May 2017 12:13:48 +0200 Subject: [PATCH] Do not return shortened error type any more --- .../acme4j/exception/AcmeServerException.java | 13 ------------- .../acme4j/connector/DefaultConnectionTest.java | 2 -- 2 files changed, 15 deletions(-) diff --git a/acme4j-client/src/main/java/org/shredzone/acme4j/exception/AcmeServerException.java b/acme4j-client/src/main/java/org/shredzone/acme4j/exception/AcmeServerException.java index 3adc4f14..7c0010eb 100644 --- a/acme4j-client/src/main/java/org/shredzone/acme4j/exception/AcmeServerException.java +++ b/acme4j-client/src/main/java/org/shredzone/acme4j/exception/AcmeServerException.java @@ -15,8 +15,6 @@ package org.shredzone.acme4j.exception; import java.util.Objects; -import org.shredzone.acme4j.util.AcmeUtils; - /** * An exception that is thrown when the ACME server returned an error. It contains * further details of the cause. @@ -47,15 +45,4 @@ public class AcmeServerException extends AcmeException { return type; } - /** - * Returns the ACME error type. This is the last part of the type URN, e.g. - * {@code "malformed"} on {@code "urn:ietf:params:acme:error:malformed"}. - * - * @return ACME error type, or {@code null} if this is not an - * {@code "urn:ietf:params:acme:error"} - */ - public String getAcmeErrorType() { - return AcmeUtils.stripErrorPrefix(type); - } - } diff --git a/acme4j-client/src/test/java/org/shredzone/acme4j/connector/DefaultConnectionTest.java b/acme4j-client/src/test/java/org/shredzone/acme4j/connector/DefaultConnectionTest.java index 01fbdbea..fd2a8ed2 100644 --- a/acme4j-client/src/test/java/org/shredzone/acme4j/connector/DefaultConnectionTest.java +++ b/acme4j-client/src/test/java/org/shredzone/acme4j/connector/DefaultConnectionTest.java @@ -433,7 +433,6 @@ public class DefaultConnectionTest { } catch (AcmeServerException ex) { assertThat(ex.getType(), is("urn:ietf:params:acme:error:unauthorized")); assertThat(ex.getMessage(), is("Invalid response: 404")); - assertThat(ex.getAcmeErrorType(), is("unauthorized")); } catch (AcmeException ex) { fail("Expected an AcmeServerException"); } @@ -469,7 +468,6 @@ public class DefaultConnectionTest { } catch (AcmeServerException ex) { assertThat(ex.getType(), is("urn:zombie:error:apocalypse")); assertThat(ex.getMessage(), is("Zombie apocalypse in progress")); - assertThat(ex.getAcmeErrorType(), is(nullValue())); } catch (AcmeException ex) { fail("Expected an AcmeServerException"); }