github
/
Xray-core
mirror of https://github.com/XTLS/Xray-core
1
0
Fork 0
Code Issues Releases Wiki Activity

DNS outbound: Prevent panic from rejecting invalid domain (#4903) 

Fixes https://github.com/XTLS/Xray-core/pull/4824#issuecomment-3078811352
pull/4909/head
风扇滑翔翼 2025-07-19 09:43:06 +08:00 committed by RPRX
parent 79c6f99384
commit 83686ebfaa
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
proxy/dns/dns.go
View File

@ -338,11 +338,16 @@ func (h *Handler) rejectNonIPQuery(id uint16, qType dnsmessage.Type, domain stri
}) })
builder.EnableCompression() builder.EnableCompression()
common.Must(builder.StartQuestions()) common.Must(builder.StartQuestions())
common.Must(builder.Question(dnsmessage.Question{ err := builder.Question(dnsmessage.Question{
Name: dnsmessage.MustNewName(domain), Name: dnsmessage.MustNewName(domain),
Class: dnsmessage.ClassINET, Class: dnsmessage.ClassINET,
Type: qType, Type: qType,
})) })
if err != nil {
errors.LogInfo(context.Background(), "unexpected domain ", domain, " when building reject message: ", err)
b.Release()
return
}
msgBytes, err := builder.Finish() msgBytes, err := builder.Finish()
if err != nil { if err != nil {