From ebdce87f5f1d7c18a2c3ba62beb9c86872349168 Mon Sep 17 00:00:00 2001 From: Andrea Ceccanti Date: Fri, 24 Feb 2017 14:55:01 +0100 Subject: [PATCH] Avoid NPEs for incorrect client logo URLs --- .../src/main/java/org/mitre/openid/connect/web/ClientAPI.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientAPI.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientAPI.java index 2cce0e228..25fb8fcf2 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientAPI.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientAPI.java @@ -513,6 +513,10 @@ public class ClientAPI { } else { // get the image from cache CachedImage image = clientLogoLoadingService.getLogo(client); + + if (image == null){ + return new ResponseEntity<>(HttpStatus.NOT_FOUND); + } HttpHeaders headers = new HttpHeaders(); headers.setContentType(MediaType.parseMediaType(image.getContentType()));