From d16c3c6368a4039ac6918f8a68960bfaac899dab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Franti=C5=A1ek=20Bu=C4=8D=C3=ADk?= Date: Fri, 3 Jun 2022 12:42:03 +0200 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20Fix=20SAML=20Claim=20sour?= =?UTF-8?q?ce=20when=20singleValue=20to=20use=20joiner?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../server/claims/sources/SamlAttributeClaimSource.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/perun-oidc-server/src/main/java/cz/muni/ics/oidc/server/claims/sources/SamlAttributeClaimSource.java b/perun-oidc-server/src/main/java/cz/muni/ics/oidc/server/claims/sources/SamlAttributeClaimSource.java index ed5cd28ec..7e5f5815a 100644 --- a/perun-oidc-server/src/main/java/cz/muni/ics/oidc/server/claims/sources/SamlAttributeClaimSource.java +++ b/perun-oidc-server/src/main/java/cz/muni/ics/oidc/server/claims/sources/SamlAttributeClaimSource.java @@ -10,7 +10,10 @@ import cz.muni.ics.oidc.server.claims.ClaimSourceProduceContext; import cz.muni.ics.oidc.server.claims.ClaimUtils; import java.util.Collections; import java.util.Set; +import java.util.StringJoiner; +import lombok.extern.slf4j.Slf4j; +@Slf4j public class SamlAttributeClaimSource extends ClaimSource { private static final String ATTRIBUTE = "attribute"; @@ -57,9 +60,9 @@ public class SamlAttributeClaimSource extends ClaimSource { if (attrValue == null || attrValue.length == 0) { return JsonNodeFactory.instance.nullNode(); } else { - StringBuilder finalStr = new StringBuilder(separator); + StringJoiner finalStr = new StringJoiner(separator); for (String s: attrValue) { - finalStr.append(s); + finalStr.add(s); } return JsonNodeFactory.instance.textNode(finalStr.toString()); }