github
/
OpenID-Connect-Java-Spring-Server
mirror of https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix a bug where a client is deleted before details looked up. Also return 204 on success

pull/341/merge
Josh Mandel 2013-05-31 11:20:57 -07:00 committed by Justin Richer
parent 317526b1ad
commit b0dc5fb4e2
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
openid-connect-server/src/main/java/org/mitre/openid/connect/web/ClientDynamicRegistrationEndpoint.java
View File

@ -306,21 +306,11 @@ public class ClientDynamicRegistrationEndpoint {
clientService.deleteClient(client); clientService.deleteClient(client);
// we return the token that we got in
OAuth2AuthenticationDetails details = (OAuth2AuthenticationDetails) auth.getDetails();
OAuth2AccessTokenEntity token = tokenService.readAccessToken(details.getTokenValue());
// TODO: urlencode the client id for safety?
RegisteredClient registered = new RegisteredClient(client, token.getValue(), config.getIssuer() + "register/" + client.getClientId());
// send it all out to the view // send it all out to the view
m.addAttribute("client", client); m.addAttribute("client", client);
m.addAttribute("code", HttpStatus.OK); // http 200 m.addAttribute("code", HttpStatus.NO_CONTENT); // http 204
//m.addAttribute("token", token);
// TODO: urlencode the client id for safety?
//m.addAttribute("uri", config.getIssuer() + "register/" + client.getClientId());
return "clientInformationResponseView"; return "httpCodeView";
} else { } else {
// client mismatch // client mismatch
logger.error("readClientConfiguration failed, client ID mismatch: " logger.error("readClientConfiguration failed, client ID mismatch: "