github
/
OpenID-Connect-Java-Spring-Server
mirror of https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Works; about to do some cleanup

pull/165/merge
Amanda Anganes 2012-08-06 13:40:27 -04:00
parent 2f28cf33e7
commit ae44bd5e0c
2 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
openid-connect-server/src/main/java/org/mitre/oauth2/service/impl/DefaultOAuth2ProviderTokenService.java
View File

@ -42,8 +42,6 @@ import org.springframework.security.oauth2.provider.token.TokenEnhancer;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional; import org.springframework.transaction.annotation.Transactional;
import com.google.common.collect.Sets;
/** /**
* @author jricher * @author jricher
@ -82,22 +80,7 @@ public class DefaultOAuth2ProviderTokenService implements OAuth2TokenEntityServi
token.setClient(client); token.setClient(client);
// inherit the scope from the auth // inherit the scope from the auth
// this lets us match which scope is requested token.setScope(clientAuth.getScope());
if (client.isScoped()) {
// restrict granted scopes to a valid subset of those
Set<String> validScopes = Sets.newHashSet();
for (String requested : clientAuth.getScope()) {
if (client.getScope().contains(requested)) {
validScopes.add(requested);
} else {
logger.warn("Client " + client.getClientId() + " requested out of permission scope: " + requested);
}
}
token.setScope(validScopes);
}
// make it expire if necessary // make it expire if necessary
// TODO: pending upstream updates, check for 0 or -1 value here // TODO: pending upstream updates, check for 0 or -1 value here

34
openid-connect-server/src/main/java/org/mitre/openid/connect/token/JdbcUserApprovalHandler.java
View File

@ -27,6 +27,7 @@ import org.mitre.openid.connect.service.ApprovedSiteService;
import org.mitre.openid.connect.service.WhitelistedSiteService; import org.mitre.openid.connect.service.WhitelistedSiteService;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.security.core.Authentication; import org.springframework.security.core.Authentication;
import org.springframework.security.oauth2.common.exceptions.InvalidScopeException;
import org.springframework.security.oauth2.provider.AuthorizationRequest; import org.springframework.security.oauth2.provider.AuthorizationRequest;
import org.springframework.security.oauth2.provider.ClientDetails; import org.springframework.security.oauth2.provider.ClientDetails;
import org.springframework.security.oauth2.provider.ClientDetailsService; import org.springframework.security.oauth2.provider.ClientDetailsService;
@ -78,6 +79,7 @@ public class JdbcUserApprovalHandler implements UserApprovalHandler {
//First, check database to see if the user identified by the userAuthentication has stored an approval decision //First, check database to see if the user identified by the userAuthentication has stored an approval decision
//getName may not be filled in? TODO: investigate
String userId = userAuthentication.getName(); String userId = userAuthentication.getName();
ClientDetails client = clientDetailsService.loadClientByClientId(authorizationRequest.getClientId()); ClientDetails client = clientDetailsService.loadClientByClientId(authorizationRequest.getClientId());
@ -96,15 +98,15 @@ public class JdbcUserApprovalHandler implements UserApprovalHandler {
} }
WhitelistedSite ws = whitelistedSiteService.getByClientDetails(client); WhitelistedSite ws = whitelistedSiteService.getByClientDetails(client);
if (ws != null) { if (ws != null && scopesMatch(ws, authorizationRequest)) {
//Create an approved site //Create an approved site
ApprovedSite newAP = new ApprovedSite(); ApprovedSite newAP = new ApprovedSite();
newAP.setClientDetails((ClientDetailsEntity)client);
newAP.setAccessDate(new Date()); newAP.setAccessDate(new Date());
newAP.setWhitelistedSite(ws); newAP.setWhitelistedSite(ws);
newAP.setAllowedScopes(ws.getAllowedScopes()); newAP.setAllowedScopes(ws.getAllowedScopes());
newAP.setCreationDate(new Date()); newAP.setCreationDate(new Date());
newAP.setUserId(userId); newAP.setUserId(userId);
//TODO set timeout date?
approvedSiteService.save(newAP); approvedSiteService.save(newAP);
return true; return true;
@ -117,6 +119,9 @@ public class JdbcUserApprovalHandler implements UserApprovalHandler {
//Only store an ApprovedSite if the user has checked "remember this decision": //Only store an ApprovedSite if the user has checked "remember this decision":
if (authorizationRequest.getApprovalParameters().get("remember") != null) { if (authorizationRequest.getApprovalParameters().get("remember") != null) {
//TODO: Remember may eventually have an option to remember for a specific amount
//of time; this would set the ApprovedSite.timeout.
//Make a new AP //Make a new AP
ApprovedSite newAP = new ApprovedSite(); ApprovedSite newAP = new ApprovedSite();
newAP.setAccessDate(new Date()); newAP.setAccessDate(new Date());
@ -158,15 +163,15 @@ public class JdbcUserApprovalHandler implements UserApprovalHandler {
ClientDetails client = clientDetailsService.loadClientByClientId(authReq.getClientId()); ClientDetails client = clientDetailsService.loadClientByClientId(authReq.getClientId());
String scopes = authReq.getAuthorizationParameters().get("scope"); String scopes = authReq.getAuthorizationParameters().get("scope");
Set<String> allowedScopes = Sets.newHashSet(Splitter.on(" ").split(scopes)); Set<String> requestedScopes = Sets.newHashSet(Splitter.on(" ").split(scopes));
if (!(ap.getClientDetails().getClientId()).equalsIgnoreCase(client.getClientId())) { if (!(ap.getClientDetails().getClientId()).equals(client.getClientId())) {
return false; return false;
} }
if (!(ap.getUserId()).equalsIgnoreCase(userId)) { if (!(ap.getUserId()).equals(userId)) {
return false; return false;
} }
for (String scope : allowedScopes) { for (String scope : requestedScopes) {
if (!ap.getAllowedScopes().contains(scope)) { if (!ap.getAllowedScopes().contains(scope)) {
return false; return false;
} }
@ -175,4 +180,21 @@ public class JdbcUserApprovalHandler implements UserApprovalHandler {
return true; return true;
} }
private boolean scopesMatch(WhitelistedSite ws, AuthorizationRequest authorizationRequest) {
String scopes = authorizationRequest.getAuthorizationParameters().get("scope");
Set<String> authRequestScopes = Sets.newHashSet(Splitter.on(" ").split(scopes));
Set<String> wsScopes = ws.getAllowedScopes();
for (String scope : authRequestScopes) {
if (!wsScopes.contains(scope)) {
throw new InvalidScopeException("Invalid scope: " + scope, wsScopes);
}
}
return true;
}
} }