diff --git a/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/HmacSigner.java b/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/HmacSigner.java index c83183f7a..23689b719 100644 --- a/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/HmacSigner.java +++ b/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/HmacSigner.java @@ -142,9 +142,9 @@ public class HmacSigner extends AbstractJwtSigner implements InitializingBean { mac.update(signatureBase.getBytes("UTF-8")); } catch (GeneralSecurityException e) { - logger.error("GeneralSecurityException in HmacSigner.java: " + e.getStackTrace()); + logger.error("GeneralSecurityException in HmacSigner.java: ", e); } catch (UnsupportedEncodingException e) { - logger.error("UnsupportedEncodingException in HmacSigner.java: " + e.getStackTrace()); + logger.error("UnsupportedEncodingException in HmacSigner.java: ", e); } byte[] sigBytes = mac.doFinal(); diff --git a/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/RsaSigner.java b/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/RsaSigner.java index ce042a40a..059d499d1 100644 --- a/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/RsaSigner.java +++ b/openid-connect-common/src/main/java/org/mitre/jwt/signer/impl/RsaSigner.java @@ -184,9 +184,9 @@ public class RsaSigner extends AbstractJwtSigner implements InitializingBean { sig = (new String(Base64.encodeBase64URLSafe(sigBytes))).replace("=", ""); } catch (GeneralSecurityException e) { - logger.error("GeneralSecurityException in RsaSigner.java: " + e.getStackTrace()); + logger.error("GeneralSecurityException in RsaSigner.java: ", e); } catch (UnsupportedEncodingException e) { - logger.error("UnsupportedEncodingException in RsaSigner.java: " + e.getStackTrace()); + logger.error("UnsupportedEncodingException in RsaSigner.java: ", e); } return sig; @@ -281,9 +281,9 @@ public class RsaSigner extends AbstractJwtSigner implements InitializingBean { signer.update(signingInput.getBytes("UTF-8")); value = signer.verify(Base64.decodeBase64(s64)); } catch (GeneralSecurityException e) { - logger.error("GeneralSecurityException in RsaSigner.java: " + e.getStackTrace()); + logger.error("GeneralSecurityException in RsaSigner.java: ", e); } catch (UnsupportedEncodingException e) { - logger.error("UnsupportedEncodingException in RsaSigner.java: " + e.getStackTrace()); + logger.error("UnsupportedEncodingException in RsaSigner.java: ", e); } return value; diff --git a/openid-connect-common/src/main/java/org/mitre/key/fetch/KeyFetcher.java b/openid-connect-common/src/main/java/org/mitre/key/fetch/KeyFetcher.java index ead7642c0..45cf39d15 100644 --- a/openid-connect-common/src/main/java/org/mitre/key/fetch/KeyFetcher.java +++ b/openid-connect-common/src/main/java/org/mitre/key/fetch/KeyFetcher.java @@ -65,9 +65,9 @@ public class KeyFetcher { X509Certificate cert = (X509Certificate) factory.generateCertificate(x509Stream); key = cert.getPublicKey(); } catch (HttpClientErrorException e) { - logger.error("HttpClientErrorException in KeyFetcher.java: " + e.getStackTrace()); + logger.error("HttpClientErrorException in KeyFetcher.java: ", e); } catch (CertificateException e) { - logger.error("CertificateException in KeyFetcher.java: " + e.getStackTrace()); + logger.error("CertificateException in KeyFetcher.java: ", e); } return key; @@ -97,11 +97,11 @@ public class KeyFetcher { } } catch (HttpClientErrorException e) { - logger.error("HttpClientErrorException in KeyFetcher.java: " + e.getStackTrace()); + logger.error("HttpClientErrorException in KeyFetcher.java: ", e); } catch (NoSuchAlgorithmException e) { - logger.error("NoSuchAlgorithmException in KeyFetcher.java: " + e.getStackTrace()); + logger.error("NoSuchAlgorithmException in KeyFetcher.java: ", e); } catch (InvalidKeySpecException e) { - logger.error("InvalidKeySpecException in KeyFetcher.java: " + e.getStackTrace()); + logger.error("InvalidKeySpecException in KeyFetcher.java: ", e); } return pub; } diff --git a/openid-connect-common/src/main/java/org/mitre/openid/connect/view/JwkKeyListView.java b/openid-connect-common/src/main/java/org/mitre/openid/connect/view/JwkKeyListView.java index 2e8eada74..64260edd4 100644 --- a/openid-connect-common/src/main/java/org/mitre/openid/connect/view/JwkKeyListView.java +++ b/openid-connect-common/src/main/java/org/mitre/openid/connect/view/JwkKeyListView.java @@ -122,7 +122,7 @@ public class JwkKeyListView extends AbstractView { } catch (IOException e) { - logger.error("IOException in JwkKeyListView.java: " + e.getStackTrace()); + logger.error("IOException in JwkKeyListView.java: ", e); } diff --git a/openid-connect-common/src/main/java/org/mitre/openid/connect/view/X509CertificateView.java b/openid-connect-common/src/main/java/org/mitre/openid/connect/view/X509CertificateView.java index f7b54738c..53123a9de 100644 --- a/openid-connect-common/src/main/java/org/mitre/openid/connect/view/X509CertificateView.java +++ b/openid-connect-common/src/main/java/org/mitre/openid/connect/view/X509CertificateView.java @@ -94,15 +94,15 @@ public class X509CertificateView extends AbstractView { X509Certificate cert = v3CertGen.generate(rsaSigner.getPrivateKey()); pemWriter.writeObject(cert); } catch (CertificateEncodingException e) { - logger.error("CertificateEncodingException in X509CertificateView.java: " + e.getStackTrace()); + logger.error("CertificateEncodingException in X509CertificateView.java: ", e); } catch (InvalidKeyException e) { - logger.error("InvalidKeyException in X509CertificateView.java: " + e.getStackTrace()); + logger.error("InvalidKeyException in X509CertificateView.java: ", e); } catch (IllegalStateException e) { - logger.error("IllegalStateException in X509CertificateView.java" + e.getStackTrace()); + logger.error("IllegalStateException in X509CertificateView.java", e); } catch (NoSuchAlgorithmException e) { - logger.error("NoSuchAlgorithmException in X509CertificateView.java" + e.getStackTrace()); + logger.error("NoSuchAlgorithmException in X509CertificateView.java", e); } catch (SignatureException e) { - logger.error("SignatureException in X509CertificateView.java" + e.getStackTrace()); + logger.error("SignatureException in X509CertificateView.java", e); } finally { pemWriter.flush(); writer.flush(); diff --git a/openid-connect-server/src/main/java/org/mitre/oauth2/view/TokenIntrospection.java b/openid-connect-server/src/main/java/org/mitre/oauth2/view/TokenIntrospection.java index fcc32246c..13f2b5151 100644 --- a/openid-connect-server/src/main/java/org/mitre/oauth2/view/TokenIntrospection.java +++ b/openid-connect-server/src/main/java/org/mitre/oauth2/view/TokenIntrospection.java @@ -118,7 +118,7 @@ public class TokenIntrospection extends AbstractView { } catch (IOException e) { - logger.error("IOException occurred in TokenIntrospection.java: " + e.getStackTrace()); + logger.error("IOException occurred in TokenIntrospection.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientAssociateView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientAssociateView.java index 4238928cf..2b76f489d 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientAssociateView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientAssociateView.java @@ -52,7 +52,7 @@ public class ClientAssociateView extends AbstractView { } catch (IOException e) { - logger.error("IOException " + e.getStackTrace()); + logger.error("IOException ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientUpdateView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientUpdateView.java index d41fab076..3885ce204 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientUpdateView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ClientUpdateView.java @@ -47,7 +47,7 @@ public class ClientUpdateView extends AbstractView { } catch (IOException e) { - logger.error("IOException " + e.getStackTrace()); + logger.error("IOException ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ExceptionAsJSONView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ExceptionAsJSONView.java index 03234edf9..aa523726f 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ExceptionAsJSONView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/ExceptionAsJSONView.java @@ -68,7 +68,7 @@ public class ExceptionAsJSONView extends AbstractView { } catch (IOException e) { - logger.error("IOException in ExceptionAsJSONView.java: " + e.getStackTrace()); + logger.error("IOException in ExceptionAsJSONView.java: ", e); } } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONClientView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONClientView.java index adb0f5daf..2cf077efc 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONClientView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONClientView.java @@ -66,7 +66,7 @@ public class JSONClientView extends AbstractView { } catch (IOException e) { - logger.error("IOException in JSONClientView.java: " + e.getStackTrace()); + logger.error("IOException in JSONClientView.java: ", e); } } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONUserInfoView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONUserInfoView.java index 01c330432..f90ed82df 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONUserInfoView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JSONUserInfoView.java @@ -79,7 +79,7 @@ public class JSONUserInfoView extends AbstractView { } catch (IOException e) { - logger.error("IOException in JSONUserInfoView.java: " + e.getStackTrace()); + logger.error("IOException in JSONUserInfoView.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JsonEntityView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JsonEntityView.java index d1aed0992..3261540dc 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JsonEntityView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/JsonEntityView.java @@ -61,7 +61,7 @@ public class JsonEntityView extends AbstractView { } catch (IOException e) { - logger.error("IOException in JsonEntityView.java: " + e.getStackTrace()); + logger.error("IOException in JsonEntityView.java: ", e); } } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/POCOUserInfoView.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/POCOUserInfoView.java index d4fab3201..9714d9753 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/POCOUserInfoView.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/POCOUserInfoView.java @@ -80,7 +80,7 @@ public class POCOUserInfoView extends AbstractView { } catch (IOException e) { - logger.error("IOException in POCOUserInfoView.java: " + e.getStackTrace()); + logger.error("IOException in POCOUserInfoView.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/StatsSummary.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/StatsSummary.java index 135f69912..eba25548b 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/view/StatsSummary.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/view/StatsSummary.java @@ -61,7 +61,7 @@ public class StatsSummary extends AbstractView { } catch (IOException e) { - logger.error("IOException in JSONClientView.java: " + e.getStackTrace()); + logger.error("IOException in JSONClientView.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/swd/view/JsonOpenIdConfigurationView.java b/openid-connect-server/src/main/java/org/mitre/swd/view/JsonOpenIdConfigurationView.java index 200c45937..2ae958739 100644 --- a/openid-connect-server/src/main/java/org/mitre/swd/view/JsonOpenIdConfigurationView.java +++ b/openid-connect-server/src/main/java/org/mitre/swd/view/JsonOpenIdConfigurationView.java @@ -76,7 +76,7 @@ public class JsonOpenIdConfigurationView extends AbstractView { } catch (IOException e) { - logger.error("IOException in JsonOpenIdConfigurationView.java: " + e.getStackTrace()); + logger.error("IOException in JsonOpenIdConfigurationView.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/swd/view/SwdResponse.java b/openid-connect-server/src/main/java/org/mitre/swd/view/SwdResponse.java index c995d9b03..f996ad3f0 100644 --- a/openid-connect-server/src/main/java/org/mitre/swd/view/SwdResponse.java +++ b/openid-connect-server/src/main/java/org/mitre/swd/view/SwdResponse.java @@ -86,7 +86,7 @@ public class SwdResponse extends AbstractView { } catch (IOException e) { - logger.error("IOException in SwdResponse.java: " + e.getStackTrace()); + logger.error("IOException in SwdResponse.java: ", e); } diff --git a/openid-connect-server/src/main/java/org/mitre/swd/view/XrdJsonResponse.java b/openid-connect-server/src/main/java/org/mitre/swd/view/XrdJsonResponse.java index 35d0e66a0..e1803a3e2 100644 --- a/openid-connect-server/src/main/java/org/mitre/swd/view/XrdJsonResponse.java +++ b/openid-connect-server/src/main/java/org/mitre/swd/view/XrdJsonResponse.java @@ -98,7 +98,7 @@ public class XrdJsonResponse extends AbstractView { } catch (IOException e) { - logger.error("IOException in XrdJsonResponse.java: " + e.getStackTrace()); + logger.error("IOException in XrdJsonResponse.java: ", e); } }