github
/
OpenID-Connect-Java-Spring-Server
mirror of https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

A little more error-checking

pull/650/head
arielak 2014-07-29 15:42:31 -04:00
parent 7d66b15a0f
commit 4eafb4efa9
1 changed files with 93 additions and 92 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
openid-connect-server/src/main/java/org/mitre/openid/connect/service/impl/MITREidDataService_1_0.java
View File

@ -520,7 +520,6 @@ public class MITREidDataService_1_0 implements MITREidDataService {
switch (tok) { switch (tok) {
case NAME: case NAME:
String name = reader.nextName(); String name = reader.nextName();
// find out which member it is // find out which member it is
if (name.equals(CLIENTS)) { if (name.equals(CLIENTS)) {
readClients(reader); readClients(reader);
@ -567,18 +566,18 @@ public class MITREidDataService_1_0 implements MITREidDataService {
String clientId = null; String clientId = null;
Long authHolderId = null; Long authHolderId = null;
while (reader.hasNext()) { while (reader.hasNext()) {
switch (reader.peek()) {
case END_OBJECT:
continue;
case NAME:
String name = reader.nextName(); String name = reader.nextName();
if (reader.peek() == JsonToken.NULL) { if (reader.peek() == JsonToken.NULL) {
reader.skipValue(); reader.skipValue();
} else if (name.equals("id")) { } else if (name.equals("id")) {
currentId = reader.nextLong(); currentId = reader.nextLong();
} else if (name.equals("expiration")) { } else if (name.equals("expiration")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
Date date = utcToDate(reader.nextString()); Date date = utcToDate(reader.nextString());
token.setExpiration(date); token.setExpiration(date);
}
} else if (name.equals("value")) { } else if (name.equals("value")) {
token.setValue(reader.nextString()); token.setValue(reader.nextString());
} else if (name.equals("clientId")) { } else if (name.equals("clientId")) {
@ -589,6 +588,12 @@ public class MITREidDataService_1_0 implements MITREidDataService {
logger.debug("Found unexpected entry"); logger.debug("Found unexpected entry");
reader.skipValue(); reader.skipValue();
} }
break;
default:
logger.debug("Found unexpected entry");
reader.skipValue();
continue;
}
} }
reader.endObject(); reader.endObject();
Long newId = tokenRepository.saveRefreshToken(token).getId(); Long newId = tokenRepository.saveRefreshToken(token).getId();
@ -626,18 +631,18 @@ public class MITREidDataService_1_0 implements MITREidDataService {
Long refreshTokenId = null; Long refreshTokenId = null;
Long idTokenId = null; Long idTokenId = null;
while (reader.hasNext()) { while (reader.hasNext()) {
switch (reader.peek()) {
case END_OBJECT:
continue;
case NAME:
String name = reader.nextName(); String name = reader.nextName();
if (reader.peek() == JsonToken.NULL) { if (reader.peek() == JsonToken.NULL) {
reader.skipValue(); reader.skipValue();
} else if (name.equals("id")) { } else if (name.equals("id")) {
currentId = reader.nextLong(); currentId = reader.nextLong();
} else if (name.equals("expiration")) { } else if (name.equals("expiration")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
Date date = utcToDate(reader.nextString()); Date date = utcToDate(reader.nextString());
token.setExpiration(date); token.setExpiration(date);
}
} else if (name.equals("value")) { } else if (name.equals("value")) {
token.setValue(reader.nextString()); token.setValue(reader.nextString());
} else if (name.equals("clientId")) { } else if (name.equals("clientId")) {
@ -645,17 +650,9 @@ public class MITREidDataService_1_0 implements MITREidDataService {
} else if (name.equals("authenticationHolderId")) { } else if (name.equals("authenticationHolderId")) {
authHolderId = reader.nextLong(); authHolderId = reader.nextLong();
} else if (name.equals("refreshTokenId")) { } else if (name.equals("refreshTokenId")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
refreshTokenId = reader.nextLong(); refreshTokenId = reader.nextLong();
}
} else if (name.equals("idTokenId")) { } else if (name.equals("idTokenId")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
idTokenId = reader.nextLong(); idTokenId = reader.nextLong();
}
} else if (name.equals("scope")) { } else if (name.equals("scope")) {
Set<String> scope = readSet(reader); Set<String> scope = readSet(reader);
token.setScope(scope); token.setScope(scope);
@ -665,6 +662,12 @@ public class MITREidDataService_1_0 implements MITREidDataService {
logger.debug("Found unexpected entry"); logger.debug("Found unexpected entry");
reader.skipValue(); reader.skipValue();
} }
break;
default:
logger.debug("Found unexpected entry");
reader.skipValue();
continue;
}
} }
reader.endObject(); reader.endObject();
Long newId = tokenRepository.saveAccessToken(token).getId(); Long newId = tokenRepository.saveAccessToken(token).getId();
@ -848,28 +851,16 @@ public class MITREidDataService_1_0 implements MITREidDataService {
} else if (name.equals("id")) { } else if (name.equals("id")) {
currentId = reader.nextLong(); currentId = reader.nextLong();
} else if (name.equals("accessDate")) { } else if (name.equals("accessDate")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
Date date = utcToDate(reader.nextString()); Date date = utcToDate(reader.nextString());
site.setAccessDate(date); site.setAccessDate(date);
}
} else if (name.equals("clientId")) { } else if (name.equals("clientId")) {
site.setClientId(reader.nextString()); site.setClientId(reader.nextString());
} else if (name.equals("creationDate")) { } else if (name.equals("creationDate")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
Date date = utcToDate(reader.nextString()); Date date = utcToDate(reader.nextString());
site.setCreationDate(date); site.setCreationDate(date);
}
} else if (name.equals("timeoutDate")) { } else if (name.equals("timeoutDate")) {
if (reader.peek() == JsonToken.NULL) {
reader.nextNull();
} else {
Date date = utcToDate(reader.nextString()); Date date = utcToDate(reader.nextString());
site.setTimeoutDate(date); site.setTimeoutDate(date);
}
} else if (name.equals("userId")) { } else if (name.equals("userId")) {
site.setUserId(reader.nextString()); site.setUserId(reader.nextString());
} else if (name.equals("allowedScopes")) { } else if (name.equals("allowedScopes")) {
@ -879,6 +870,10 @@ public class MITREidDataService_1_0 implements MITREidDataService {
WhitelistedSite wlSite = new WhitelistedSite(); WhitelistedSite wlSite = new WhitelistedSite();
reader.beginObject(); reader.beginObject();
while (reader.hasNext()) { while (reader.hasNext()) {
switch (reader.peek()) {
case END_OBJECT:
continue;
case NAME:
String wlName = reader.nextName(); String wlName = reader.nextName();
if (wlName.equals("id")) { if (wlName.equals("id")) {
//not needed //not needed
@ -894,6 +889,12 @@ public class MITREidDataService_1_0 implements MITREidDataService {
logger.debug("Found unexpected entry"); logger.debug("Found unexpected entry");
reader.skipValue(); reader.skipValue();
} }
break;
default:
logger.debug("Found unexpected entry");
reader.skipValue();
continue;
}
} }
reader.endObject(); reader.endObject();
wlSite = wlSiteRepository.save(wlSite); wlSite = wlSiteRepository.save(wlSite);