From 25b9940a684912169ffdab9a607f85fd19dfe24f Mon Sep 17 00:00:00 2001 From: Justin Richer Date: Tue, 19 Feb 2013 17:07:17 -0500 Subject: [PATCH] request object endpoint is a placeholder, cleaning out for now --- .../RequestObjectAuthorizationEndpoint.java | 92 ++----------------- 1 file changed, 6 insertions(+), 86 deletions(-) diff --git a/openid-connect-server/src/main/java/org/mitre/openid/connect/web/RequestObjectAuthorizationEndpoint.java b/openid-connect-server/src/main/java/org/mitre/openid/connect/web/RequestObjectAuthorizationEndpoint.java index 8a43a93a9..9fdcede11 100644 --- a/openid-connect-server/src/main/java/org/mitre/openid/connect/web/RequestObjectAuthorizationEndpoint.java +++ b/openid-connect-server/src/main/java/org/mitre/openid/connect/web/RequestObjectAuthorizationEndpoint.java @@ -5,11 +5,8 @@ import java.util.Map; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.mitre.jwt.model.Jwt; -import org.mitre.jwt.model.JwtClaims; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.oauth2.provider.endpoint.AuthorizationEndpoint; -import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestParam; import org.springframework.web.bind.support.SessionStatus; @@ -31,91 +28,14 @@ public class RequestObjectAuthorizationEndpoint { public ModelAndView authorizeRequestObject(Map model, @RequestParam("request") String jwtString, @RequestParam Map parameters, SessionStatus sessionStatus, Principal principal) { - Jwt jwt = Jwt.parse(jwtString); - JwtClaims claims = jwt.getClaims(); - - // TODO: validate JWT signature - - String clientId = claims.getClaimAsString("client_id"); - //Set scopes = Sets.newHashSet(Splitter.on(" ").split(claims.getClaimAsString("scope"))); - - // Manually initialize auth request instead of using @ModelAttribute - // to make sure it comes from request instead of the session - - // TODO: check parameter consistency, move keys to constants - /* - * if (in Claims): - * if (in params): - * if (equal): - * all set - * else (not equal): - * error - * else (not in params): - * add to params - * else (not in claims): - * we don't care - */ - - String responseTypes = claims.getClaimAsString("response_type"); - if (responseTypes != null) { - parameters.put("response_type", responseTypes); - } - - if (clientId != null) { - parameters.put("client_id", clientId); - } - - if (claims.getClaimAsString("redirect_uri") != null) { - if (parameters.containsKey("redirect_uri") == false) { - parameters.put("redirect_uri", claims.getClaimAsString("redirect_uri")); - } - } - - String state = claims.getClaimAsString("state"); - if(state != null) { - if (parameters.containsKey("state") == false) { - parameters.put("state", state); - } - } - - String nonce = claims.getClaimAsString("nonce"); - if(nonce != null) { - if (parameters.containsKey("nonce") == false) { - parameters.put("nonce", nonce); - } - } - - String display = claims.getClaimAsString("display"); - if (display != null) { - if (parameters.containsKey("display") == false) { - parameters.put("display", display); - } - } - - String prompt = claims.getClaimAsString("prompt"); - if (prompt != null) { - if (parameters.containsKey("prompt") == false) { - parameters.put("prompt", prompt); - } - } - - String request = claims.getClaimAsString("request"); - if (request != null) { - if (parameters.containsKey("request") == false) { - parameters.put("request", request); - } - } - - String requestUri = claims.getClaimAsString("request_uri"); - if (requestUri != null) { - //The spec does not allow a client to send a request parameter AND - //link to a hosted request object at the same time, so this is an error. - //TODO: what error to throw? - } + * + * SEE Processing code in ConnectAuthorizationRequestManager.processRequestObject + * + */ - // call out to the SECOAUTH endpoint to do the real processing - return authorizationEndpoint.authorize(model, parameters.get("response_type"), parameters, sessionStatus, principal); + return null; + } }