fix(storage): unify the name of ak & sk (#527)

* multipart upload

* upload

* storage

* storage

* storage

* storage

* change ak sk name

* change ak sk name

* change ak sk name

* change ak sk name

* storage

* storage
pull/530/head
jiaxingli 2023-12-06 15:31:44 +08:00 committed by GitHub
parent 809ad9ebc8
commit 828033aed5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 74 additions and 17 deletions

View File

@ -328,8 +328,8 @@ class Boto3Client(StorageClient):
"""S3 object/file storage management class """S3 object/file storage management class
Args: Args:
s3_access_keys_id (str): S3 access key ID. ACCESS_KEY (str): S3 access key ID.
s3_secret_access_key (str): S3 secret access key. SECRET_ACCESS_KEY (str): S3 secret access key.
use_threads (bool, optional): Whether to enable multipart. Defaults to True. use_threads (bool, optional): Whether to enable multipart. Defaults to True.
multipart_chunksize (_type_, optional): Defaults to 8*MB. multipart_chunksize (_type_, optional): Defaults to 8*MB.
max_concurrency (int, optional): Defaults to 10. max_concurrency (int, optional): Defaults to 10.
@ -340,11 +340,30 @@ class Boto3Client(StorageClient):
super().__init__(boto3) super().__init__(boto3)
self.botocore = botocore self.botocore = botocore
try: try:
s3_access_key_id = os.environ["S3_ACCESS_KEY_ID"] if os.environ.get("S3_ACCESS_KEY_ID") is not None and os.environ.get("ACCESS_KEY") is not None:
s3_secret_access_key = os.environ["S3_SECRET_ACCESS_KEY_ID"] s3_access_key_id = os.environ["ACCESS_KEY"]
logger.warning("Both 'S3_ACCESS_KEY_ID' and 'ACCESS_KEY' exist, 'ACCESS_KEY' will be used by default")
elif os.environ.get("ACCESS_KEY") is None:
s3_access_key_id = os.environ["S3_ACCESS_KEY_ID"]
else:
s3_access_key_id = os.environ["ACCESS_KEY"]
if (
os.environ.get("S3_SECRET_ACCESS_KEY_ID") is not None
and os.environ.get("SECRET_ACCESS_KEY") is not None
):
s3_secret_access_key = os.environ["SECRET_ACCESS_KEY"]
logger.warning(
"Both 'S3_SECRET_ACCESS_KEY_ID' and 'SECRET_ACCESS_KEY' exist, "
"'SECRET_ACCESS_KEY' will be used by default"
)
elif os.environ.get("SECRET_ACCESS_KEY") is None:
s3_secret_access_key = os.environ["S3_SECRET_ACCESS_KEY_ID"]
else:
s3_secret_access_key = os.environ["SECRET_ACCESS_KEY"]
except KeyError as exc: except KeyError as exc:
raise RuntimeError( raise RuntimeError(
"Please set boto3 bucket 'S3_ACCESS_KEY_ID' and 'S3_SECRET_ACCESS_KEY_ID' using environment variable!" "Please set boto3 bucket 'ACCESS_KEY' and 'SECRET_ACCESS_KEY' using environment variable!"
) from exc ) from exc
self.client = self.handler.client( self.client = self.handler.client(
@ -457,8 +476,8 @@ class VolcClient(StorageClient):
"""Volc object/file storage management class """Volc object/file storage management class
Args: Args:
access_key (str): Volc access key ID. ACCESS_KEY (str): Volc access key ID.
secret_key (str): Volc secret access key. SECRET_ACCESS_KEY (str): Volc secret access key.
endpoint (str): Volc tos endpoint. endpoint (str): Volc tos endpoint.
region (str): Volc tos region. region (str): Volc tos region.
@ -466,15 +485,34 @@ class VolcClient(StorageClient):
super().__init__(tos) super().__init__(tos)
try: try:
access_key = os.environ["VOLC_ACCESS_KEY_ID"] if os.environ.get("VOLC_ACCESS_KEY_ID") is not None and os.environ.get("ACCESS_KEY") is not None:
secret_key = os.environ["VOLC_SECRET_ACCESS_KEY_ID"] access_key = os.environ["ACCESS_KEY"]
logger.warning("Both 'VOLC_ACCESS_KEY_ID' and 'ACCESS_KEY' exist, 'ACCESS_KEY' will be used by default")
elif os.environ.get("ACCESS_KEY") is None:
access_key = os.environ["VOLC_ACCESS_KEY_ID"]
else:
access_key = os.environ["ACCESS_KEY"]
if (
os.environ.get("VOLC_SECRET_ACCESS_KEY_ID") is not None
and os.environ.get("SECRET_ACCESS_KEY") is not None
):
secret_key = os.environ["SECRET_ACCESS_KEY"]
logger.warning(
"Both 'VOLC_SECRET_ACCESS_KEY_ID' and 'SECRET_ACCESS_KEY' exist, "
"'SECRET_ACCESS_KEY' will be used by default"
)
elif os.environ.get("SECRET_ACCESS_KEY") is None:
secret_key = os.environ["VOLC_SECRET_ACCESS_KEY_ID"]
else:
secret_key = os.environ["SECRET_ACCESS_KEY"]
except KeyError as exc: except KeyError as exc:
raise RuntimeError( raise RuntimeError(
"Please set 'VOLC_ACCESS_KEY_ID' and 'VOLC_SECRET_ACCESS_KEY_ID'", "Please set 'ACCESS_KEY' and 'SECRET_ACCESS_KEY'",
"using environment variable!", "using environment variable!",
) from exc ) from exc
self.client = self.handler.TosClientV2(access_key, secret_key, endpoint, region) self.client = self.handler.TosClientV2(access_key, secret_key, endpoint, region, enable_crc=False)
@staticmethod @staticmethod
def sync_upload_fileobj(handler, bucket_name: str, fp: str, saved_obj=None, **kwargs): def sync_upload_fileobj(handler, bucket_name: str, fp: str, saved_obj=None, **kwargs):
@ -623,8 +661,8 @@ class AliClient(StorageClient):
"""Ali object/file storage management class """Ali object/file storage management class
Args: Args:
access_key (str): Ali access key ID.s ACCESS_KEY (str): Ali access key ID.s
secret_key (str): Ali secret access key. SECRET_ACCESS_KEY (str): Ali secret access key.
endpoint (str): Ali tos endpoint. endpoint (str): Ali tos endpoint.
bucket_name (str): Ali tos bucket_name. bucket_name (str): Ali tos bucket_name.
@ -632,16 +670,35 @@ class AliClient(StorageClient):
super().__init__(oss2) super().__init__(oss2)
try: try:
access_key = os.environ["ALI_ACCESS_KEY_ID"] if os.environ.get("ALI_ACCESS_KEY_ID") is not None and os.environ.get("ACCESS_KEY") is not None:
secret_key = os.environ["ALI_SECRET_ACCESS_KEY_ID"] access_key = os.environ["ACCESS_KEY"]
logger.warning("Both 'ALI_ACCESS_KEY_ID' and 'ACCESS_KEY' exist, 'ACCESS_KEY' will be used by default")
elif os.environ.get("ACCESS_KEY") is None:
access_key = os.environ["ALI_ACCESS_KEY_ID"]
else:
access_key = os.environ["ACCESS_KEY"]
if (
os.environ.get("ALI_SECRET_ACCESS_KEY_ID") is not None
and os.environ.get("SECRET_ACCESS_KEY") is not None
):
secret_key = os.environ["SECRET_ACCESS_KEY"]
logger.warning(
"Both 'ALI_SECRET_ACCESS_KEY_ID' and 'SECRET_ACCESS_KEY' exist, "
"'SECRET_ACCESS_KEY' will be used by default"
)
elif os.environ.get("SECRET_ACCESS_KEY") is None:
secret_key = os.environ["ALI_SECRET_ACCESS_KEY_ID"]
else:
secret_key = os.environ["SECRET_ACCESS_KEY"]
except KeyError as exc: except KeyError as exc:
raise RuntimeError( raise RuntimeError(
"Please set 'ALI_ACCESS_KEY_ID' and 'ALI_SECRET_ACCESS_KEY_ID'", "Please set 'ACCESS_KEY' and 'SECRET_ACCESS_KEY'",
"using environment variable!", "using environment variable!",
) from exc ) from exc
self.auth = self.handler.Auth(access_key, secret_key) self.auth = self.handler.Auth(access_key, secret_key)
self.client = self.handler.Bucket(self.auth, endpoint, bucket_name) self.client = self.handler.Bucket(self.auth, endpoint, bucket_name, enable_crc=False)
@staticmethod @staticmethod
def sync_upload_fileobj(handler, fp: str, saved_obj=None, **kwargs): def sync_upload_fileobj(handler, fp: str, saved_obj=None, **kwargs):