[Gemini] make RuntimeMemTracer work correctly (#2096)

colossalai/gemini/memory_tracer/memory_stats.py

@@ -35,13 +35,31 @@ class MemStats(object):
         else:
             raise TypeError
 
-    def append_non_model_data(self, device_type: str):
+    def last_model_data(self, device_type: str):
+        if len(self._model_data_cuda_list) == 0:
+            return None
+        if device_type == 'cuda':
+            return self._model_data_cuda_list[-1]
+        elif device_type == 'cpu':
+            return self._model_data_cpu_list[-1]
+        else:
+            raise TypeError
+
+    def append_non_model_data(self, device_type: str, val=None):
+        if device_type == 'cuda':
+            if val is None:
                 if len(self._overall_cuda_list) == 0 or len(self._model_data_cuda_list) == 0:
                     return
-        if device_type == 'cuda':
                 self._non_model_data_cuda_list.append(self._overall_cuda_list[-1] - self._model_data_cuda_list[-1])
+            else:
+                self._non_model_data_cuda_list.append(val)
         elif device_type == 'cpu':
+            if val is None:
+                if len(self._overall_cuda_list) == 0 or len(self._model_data_cuda_list) == 0:
+                    return
                 self._non_model_data_cpu_list.append(self._overall_cpu_list[-1] - self._model_data_cpu_list[-1])
+            else:
+                self._non_model_data_cuda_list.append(val)
         else:
             raise TypeError
 

colossalai/gemini/memory_tracer/runtime_mem_tracer.py

@@ -76,8 +76,7 @@ class RuntimeMemTracer():
 
     def _post_backward(self):
         cuda_volume = self.param_op_hook.mem_monitor.finish()
-        self._memstats.append_model_data('cuda', cuda_volume)
+        self._memstats.append_non_model_data('cuda', cuda_volume - self._memstats.last_model_data('cuda'))
-        self._memstats.append_non_model_data('cuda')
         self.grad_hook.remove_grad_hook()
         self._restore_params()
 

colossalai/gemini/ophooks/runtime_mem_tracer_hook.py

@@ -5,7 +5,7 @@ from typing import List
 
 import torch
 
-from colossalai.gemini.memory_tracer import SyncCudaMemoryMonitor
+from colossalai.gemini.memory_tracer import MemStats, SyncCudaMemoryMonitor
 from colossalai.gemini.tensor_utils import alloc_storage, free_storage
 from colossalai.tensor.param_op_hook import ColoParamOpHook
 
@@ -51,7 +51,7 @@ class GradMemTracerHook():
 
 class ParamMemTracerHook(ColoParamOpHook):
 
-    def __init__(self, memstats, gradstats: GradMemStats) -> None:
+    def __init__(self, memstats: MemStats, gradstats: GradMemStats) -> None:
         super().__init__()
         self._training_phase = TrainingPhase.FORWARD
         self._memstats = memstats
@@ -92,7 +92,9 @@ class ParamMemTracerHook(ColoParamOpHook):
 
     def pre_op(self, params):
         cuda_volume = self.mem_monitor.finish()
-        self._memstats.append_model_data('cuda', cuda_volume)
+        last_model_data_val = self._memstats.last_model_data('cuda')
+        if last_model_data_val is not None:
+            self._memstats.append_non_model_data('cuda', cuda_volume - last_model_data_val)
         self._allocate_params_on_cuda(params)
         self.sample_model_data(params)
         self.mem_monitor.start()