From 7985fb6b95df3a3d667343138f9159ffc780485f Mon Sep 17 00:00:00 2001 From: REJack Date: Wed, 2 Dec 2020 08:26:31 +0100 Subject: [PATCH 1/5] try to avoid lgtm unused-local-variable alert --- dist/js/pages/dashboard.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dist/js/pages/dashboard.js b/dist/js/pages/dashboard.js index 9408c5814..ee65df63a 100644 --- a/dist/js/pages/dashboard.js +++ b/dist/js/pages/dashboard.js @@ -167,6 +167,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars var salesChart = new Chart(salesChartCanvas, { + // lgtm [js/unused-local-variable] type: 'line', data: salesChartData, options: salesChartOptions @@ -265,5 +266,3 @@ $(function () { options: salesGraphChartOptions }) }) - -// lgtm [js/unused-local-variable] From 5d4ed59ba900fbe7f934da22009ffe294648b0ba Mon Sep 17 00:00:00 2001 From: REJack Date: Wed, 2 Dec 2020 08:35:47 +0100 Subject: [PATCH 2/5] fix SidebarSearch --- build/js/SidebarSearch.js | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/build/js/SidebarSearch.js b/build/js/SidebarSearch.js index 3e8fc5844..2949e239b 100644 --- a/build/js/SidebarSearch.js +++ b/build/js/SidebarSearch.js @@ -101,7 +101,7 @@ class SidebarSearch { this._addNotFound() } else { endResults.each((i, result) => { - $(SELECTOR_SEARCH_RESULTS_GROUP).append(this._renderItem(escape(result.name), escape(result.link), escape(result.path))) + $(SELECTOR_SEARCH_RESULTS_GROUP).append(this._renderItem(escape(result.name), escape(result.link), result.path)) }) } @@ -160,6 +160,7 @@ class SidebarSearch { _renderItem(name, link, path) { path = path.join(` ${this.options.arrowSign} `) + name = unescape(name) if (this.options.highlightName || this.options.highlightPath) { const searchValue = $(SELECTOR_SEARCH_INPUT).val().toLowerCase() @@ -169,7 +170,7 @@ class SidebarSearch { name = name.replace( regExp, str => { - return `${str}` + return `${str}` } ) } @@ -178,20 +179,26 @@ class SidebarSearch { path = path.replace( regExp, str => { - return `${str}` + return `${str}` } ) } } - return ` -
- ${name} -
-
- ${path} -
- ` + const groupItemElement = $('', { + href: link, + class: 'list-group-item' + }) + const searchTitleElement = $('
', { + class: 'search-title' + }).html(name) + const searchPathElement = $('
', { + class: 'search-path' + }).html(path) + + groupItemElement.append(searchTitleElement).append(searchPathElement) + + return groupItemElement } _addNotFound() { @@ -243,9 +250,7 @@ $(document).on('keyup', SELECTOR_SEARCH_INPUT, event => { return } - let timer = 0 - clearTimeout(timer) - timer = setTimeout(() => { + setTimeout(() => { SidebarSearch._jQueryInterface.call($(SELECTOR_DATA_WIDGET), 'search') }, 100) }) From 90527a83d1f4d9ba0b458d5f431e0b4427bf5b71 Mon Sep 17 00:00:00 2001 From: REJack Date: Wed, 2 Dec 2020 08:38:35 +0100 Subject: [PATCH 3/5] new try to avoid lgtm unused-local-variable warning --- dist/js/pages/dashboard.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dist/js/pages/dashboard.js b/dist/js/pages/dashboard.js index ee65df63a..0212256a2 100644 --- a/dist/js/pages/dashboard.js +++ b/dist/js/pages/dashboard.js @@ -166,8 +166,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars - var salesChart = new Chart(salesChartCanvas, { - // lgtm [js/unused-local-variable] + var salesChart = new Chart(salesChartCanvas, { // lgtm [js/unused-local-variable] type: 'line', data: salesChartData, options: salesChartOptions From 8240412de9f951b0c2f1e95ec5804e18c07fe6e7 Mon Sep 17 00:00:00 2001 From: REJack Date: Wed, 2 Dec 2020 08:54:21 +0100 Subject: [PATCH 4/5] using /* */ comment to avoid warning --- dist/js/pages/dashboard.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dist/js/pages/dashboard.js b/dist/js/pages/dashboard.js index 0212256a2..a88c85f7b 100644 --- a/dist/js/pages/dashboard.js +++ b/dist/js/pages/dashboard.js @@ -166,7 +166,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars - var salesChart = new Chart(salesChartCanvas, { // lgtm [js/unused-local-variable] + var salesChart = new Chart(salesChartCanvas, { /* lgtm [js/unused-local-variable] */ type: 'line', data: salesChartData, options: salesChartOptions @@ -197,7 +197,7 @@ $(function () { // Create pie or douhnut chart // You can switch between pie and douhnut using the method below. // eslint-disable-next-line no-unused-vars - var pieChart = new Chart(pieChartCanvas, { + var pieChart = new Chart(pieChartCanvas, { /* lgtm [js/unused-local-variable] */ type: 'doughnut', data: pieData, options: pieOptions @@ -259,7 +259,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars - var salesGraphChart = new Chart(salesGraphChartCanvas, { + var salesGraphChart = new Chart(salesGraphChartCanvas, { /* lgtm [js/unused-local-variable] */ type: 'line', data: salesGraphChartData, options: salesGraphChartOptions From 983f225d6a62bc7a96385b7ae88b187e60652a2c Mon Sep 17 00:00:00 2001 From: REJack Date: Wed, 2 Dec 2020 09:48:06 +0100 Subject: [PATCH 5/5] change comment again (try no. 3) --- dist/js/pages/dashboard.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dist/js/pages/dashboard.js b/dist/js/pages/dashboard.js index a88c85f7b..56539f25b 100644 --- a/dist/js/pages/dashboard.js +++ b/dist/js/pages/dashboard.js @@ -166,7 +166,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars - var salesChart = new Chart(salesChartCanvas, { /* lgtm [js/unused-local-variable] */ + var salesChart = new Chart(salesChartCanvas, { // lgtm[js/unused-local-variable] type: 'line', data: salesChartData, options: salesChartOptions @@ -197,7 +197,7 @@ $(function () { // Create pie or douhnut chart // You can switch between pie and douhnut using the method below. // eslint-disable-next-line no-unused-vars - var pieChart = new Chart(pieChartCanvas, { /* lgtm [js/unused-local-variable] */ + var pieChart = new Chart(pieChartCanvas, { // lgtm[js/unused-local-variable] type: 'doughnut', data: pieData, options: pieOptions @@ -259,7 +259,7 @@ $(function () { // This will get the first returned node in the jQuery collection. // eslint-disable-next-line no-unused-vars - var salesGraphChart = new Chart(salesGraphChartCanvas, { /* lgtm [js/unused-local-variable] */ + var salesGraphChart = new Chart(salesGraphChartCanvas, { // lgtm[js/unused-local-variable] type: 'line', data: salesGraphChartData, options: salesGraphChartOptions