github
/
AdminLTE
mirror of https://github.com/ColorlibHQ/AdminLTE
1
0
Fork 0
Code Issues Releases Wiki Activity

Small fix for TodoList plugin (#3013) 

Properly attach the event listener to the correct selector and fix on the options passed on in the JQuery API. However, a new bug comes from this fix when both data-widget and Jquery API is set where the event listener will be triggered twice
pull/3015/head
Ryan 2020-09-11 17:57:33 +08:00 committed by GitHub
parent 16b4d30d31
commit 48743c7dee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
build/js/TodoList.js
View File

@ -64,7 +64,7 @@ class TodoList {
// Private // Private
_init() { _init() {
const $toggleSelector = $(SELECTOR_DATA_TOGGLE) const $toggleSelector = this._element
$toggleSelector.find('input:checkbox:checked').parents('li').toggleClass(CLASS_NAME_TODO_LIST_DONE) $toggleSelector.find('input:checkbox:checked').parents('li').toggleClass(CLASS_NAME_TODO_LIST_DONE)
$toggleSelector.on('change', 'input:checkbox', event => { $toggleSelector.on('change', 'input:checkbox', event => {
@ -77,15 +77,18 @@ class TodoList {
static _jQueryInterface(config) { static _jQueryInterface(config) {
return this.each(function () { return this.each(function () {
let data = $(this).data(DATA_KEY) let data = $(this).data(DATA_KEY)
const _options = $.extend({}, Default, $(this).data())
if (!data) { if (!data) {
data = new TodoList($(this), _options) data = $(this).data()
$(this).data(DATA_KEY, data)
} }
const _options = $.extend({}, Default, typeof config === 'object' ? config : data)
const plugin = new TodoList($(this), _options)
$(this).data(DATA_KEY, typeof config === 'object' ? config : data)
if (config === 'init') { if (config === 'init') {
data[config]() plugin[config]()
} }
}) })
} }