diff --git a/.eslintrc.json b/.eslintrc.json index ba58b7b20..8daf43326 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -47,14 +47,14 @@ ], "unicorn/filename-case": "off", "unicorn/import-index": "off", - "unicorn/no-fn-reference-in-iterator": "off", + "unicorn/no-array-callback-reference": "off", "unicorn/no-for-loop": "off", "unicorn/no-null": "off", "unicorn/no-unused-properties": "error", - "unicorn/prefer-dataset": "off", + "unicorn/prefer-dom-node-dataset": "off", "unicorn/prefer-includes": "off", - "unicorn/prefer-node-append": "off", - "unicorn/prefer-node-remove": "off", + "unicorn/prefer-dom-node-append": "off", + "unicorn/prefer-dom-node-remove": "off", "unicorn/prefer-number-properties": "off", "unicorn/prefer-optional-catch-binding": "off", "unicorn/prefer-query-selector": "off", diff --git a/build/js/CardRefresh.js b/build/js/CardRefresh.js index d0671edc1..f3240c4a3 100644 --- a/build/js/CardRefresh.js +++ b/build/js/CardRefresh.js @@ -36,8 +36,7 @@ const Default = { loadOnInit: true, responseType: '', overlayTemplate: '
', - onLoadStart() { - }, + onLoadStart() {}, onLoadDone(response) { return response } diff --git a/build/js/ControlSidebar.js b/build/js/ControlSidebar.js index eaa62ce7f..40f47ae9d 100644 --- a/build/js/ControlSidebar.js +++ b/build/js/ControlSidebar.js @@ -253,10 +253,8 @@ class ControlSidebar { let sidebarHeight = heights.window - heights.header - if (this._isFooterFixed()) { - if ($(SELECTOR_FOOTER).css('position') === 'fixed') { - sidebarHeight = heights.window - heights.header - heights.footer - } + if (this._isFooterFixed() && $(SELECTOR_FOOTER).css('position') === 'fixed') { + sidebarHeight = heights.window - heights.header - heights.footer } $controlSidebar.css('height', sidebarHeight) diff --git a/build/js/Dropdown.js b/build/js/Dropdown.js index 072163b9d..b67590a27 100644 --- a/build/js/Dropdown.js +++ b/build/js/Dropdown.js @@ -25,8 +25,7 @@ const CLASS_NAME_DROPDOWN_RIGHT = 'dropdown-menu-right' const CLASS_NAME_DROPDOWN_SUBMENU = 'dropdown-submenu' // TODO: this is unused; should be removed along with the extend? -const Default = { -} +const Default = {} /** * Class Definition diff --git a/build/js/PushMenu.js b/build/js/PushMenu.js index 346e8a5c5..b4ca1b349 100644 --- a/build/js/PushMenu.js +++ b/build/js/PushMenu.js @@ -58,10 +58,8 @@ class PushMenu { expand() { const $bodySelector = $(SELECTOR_BODY) - if (this._options.autoCollapseSize) { - if ($(window).width() <= this._options.autoCollapseSize) { - $bodySelector.addClass(CLASS_NAME_OPEN) - } + if (this._options.autoCollapseSize && $(window).width() <= this._options.autoCollapseSize) { + $bodySelector.addClass(CLASS_NAME_OPEN) } $bodySelector.addClass(CLASS_NAME_IS_OPENING).removeClass(`${CLASS_NAME_COLLAPSED} ${CLASS_NAME_CLOSED}`).delay(50).queue(function () { @@ -79,10 +77,8 @@ class PushMenu { collapse() { const $bodySelector = $(SELECTOR_BODY) - if (this._options.autoCollapseSize) { - if ($(window).width() <= this._options.autoCollapseSize) { - $bodySelector.removeClass(CLASS_NAME_OPEN).addClass(CLASS_NAME_CLOSED) - } + if (this._options.autoCollapseSize && $(window).width() <= this._options.autoCollapseSize) { + $bodySelector.removeClass(CLASS_NAME_OPEN).addClass(CLASS_NAME_CLOSED) } $bodySelector.addClass(CLASS_NAME_COLLAPSED) diff --git a/build/js/SidebarSearch.js b/build/js/SidebarSearch.js index 2949e239b..3b6fa0456 100644 --- a/build/js/SidebarSearch.js +++ b/build/js/SidebarSearch.js @@ -61,17 +61,17 @@ class SidebarSearch { // Public init() { - if ($(SELECTOR_DATA_WIDGET).length == 0) { + if ($(SELECTOR_DATA_WIDGET).length === 0) { return } - if ($(SELECTOR_DATA_WIDGET).next(SELECTOR_SEARCH_RESULTS).length == 0) { + if ($(SELECTOR_DATA_WIDGET).next(SELECTOR_SEARCH_RESULTS).length === 0) { $(SELECTOR_DATA_WIDGET).after( $('
', { class: CLASS_NAME_SEARCH_RESULTS }) ) } - if ($(SELECTOR_SEARCH_RESULTS).children(SELECTOR_SEARCH_LIST_GROUP).length == 0) { + if ($(SELECTOR_SEARCH_RESULTS).children(SELECTOR_SEARCH_LIST_GROUP).length === 0) { $(SELECTOR_SEARCH_RESULTS).append( $('
', { class: CLASS_NAME_LIST_GROUP }) )